chore: fix static analysis warnings

Author: two-heart

src/discof/eqvoc/fd_eqvoc_tile.c

@@ -131,8 +131,7 @@ during_frag( fd_eqvoc_tile_ctx_t * ctx,
     }
 
     uchar const * packet = fd_chunk_to_laddr_const( ctx->shred_net_in_mem, chunk );
-    fd_shred_t * shred = (fd_shred_t *)( packet + fd_disco_netmux_sig_hdr_sz( sig ) );
-    memcpy( &ctx->shred, shred, sizeof(fd_shred_t) );
+    memcpy( &ctx->shred, packet + fd_disco_netmux_sig_hdr_sz( sig ), sizeof(fd_shred_t) );
   }
 }
 

src/discof/replay/fd_replay_tile.c

@@ -1130,8 +1130,8 @@ publish_slot_notifications( fd_replay_tile_ctx_t * ctx,
     msg->slot_exec.height = block_entry_block_height;
     msg->slot_exec.transaction_count = fork->slot_ctx->slot_bank.transaction_count;
     msg->slot_exec.shred_cnt = fork->slot_ctx->shred_cnt;
-    memcpy( &msg->slot_exec.bank_hash, &fork->slot_ctx->slot_bank.banks_hash, sizeof( fd_hash_t ) );
-    memcpy( &msg->slot_exec.block_hash, &ctx->blockhash, sizeof( fd_hash_t ) );
+    msg->slot_exec.bank_hash = fork->slot_ctx->slot_bank.banks_hash;
+    msg->slot_exec.block_hash = ctx->blockhash;
     memcpy( &msg->slot_exec.identity, ctx->validator_identity_pubkey, sizeof( fd_pubkey_t ) );
     msg->slot_exec.ts = tsorig;
     NOTIFY_END;
@@ -1701,7 +1701,7 @@ exec_slice( fd_replay_tile_ctx_t * ctx,
      FD_COMPILER_MFENCE();
      block_info->flags = fd_uchar_clear_bit( block_info->flags, FD_BLOCK_FLAG_REPLAYING );
      memcpy( &block_info->block_hash, hdr->hash, sizeof(fd_hash_t) );
-     memcpy( &block_info->bank_hash, &fork->slot_ctx->slot_bank.banks_hash, sizeof(fd_hash_t) );
+     block_info->bank_hash = fork->slot_ctx->slot_bank.banks_hash;
 
      fd_block_map_publish( query );
      ctx->flags = EXEC_FLAG_FINISHED_SLOT;

src/discof/rpcserver/fd_rpc_service.c

@@ -2374,7 +2374,7 @@ fd_rpc_create_ctx(fd_rpcserver_args_t * args, fd_rpc_ctx_t ** ctx_p) {
     if( bind(gctx->tpu_socket, (const struct sockaddr*)fd_type_pun_const(&addrLocal), sizeof(addrLocal)) == -1 ) {
       FD_LOG_ERR(( "bind failed (%i-%s)", errno, strerror( errno ) ));
     }
-    memcpy( &gctx->tpu_addr, &args->tpu_addr, sizeof(struct sockaddr_in) );
+    gctx->tpu_addr = args->tpu_addr;
 
   } else {
     gctx->tpu_socket = -1;

src/flamenco/runtime/program/fd_bpf_loader_program.c

@@ -1408,7 +1408,7 @@ process_loader_upgradeable_instruction( fd_exec_instr_ctx_t * instr_ctx ) {
 
         /* copy in the authority public key into the authority address.
            https://github.com/anza-xyz/agave/blob/v2.1.14/programs/bpf_loader/src/lib.rs#L926-L928 */
-        memcpy( account_state->inner.buffer.authority_address, new_authority, sizeof(fd_pubkey_t) );
+        *account_state->inner.buffer.authority_address = *new_authority;
 
         err = fd_bpf_loader_v3_program_set_state( &account, account_state );
         if( FD_UNLIKELY( err!=FD_BINCODE_SUCCESS ) ) {
@@ -1431,7 +1431,7 @@ process_loader_upgradeable_instruction( fd_exec_instr_ctx_t * instr_ctx ) {
         /* copy in the authority public key into the upgrade authority address.
            https://github.com/anza-xyz/agave/blob/v2.1.14/programs/bpf_loader/src/lib.rs#L946-L949 */
         if( new_authority ) {
-          memcpy( account_state->inner.program_data.upgrade_authority_address, new_authority, sizeof(fd_pubkey_t) );
+          *account_state->inner.program_data.upgrade_authority_address = *new_authority;
         } else {
           account_state->inner.program_data.upgrade_authority_address = NULL;
         }