Skip to content

Update contribution guidelines wrt pre-commit hook #5201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Manciukic opened this issue May 7, 2025 · 0 comments · Fixed by #5225
Closed

Update contribution guidelines wrt pre-commit hook #5201

Manciukic opened this issue May 7, 2025 · 0 comments · Fixed by #5225
Labels
Status: WIP Indicates that an issue is currently being worked on or triaged

Comments

@Manciukic
Copy link
Contributor

What

We should update the contributor guidelines to point external contributors to use the devtool instead of the current "local" pre-commit hook setup.

Why

The pre-commit hook is unmaintained, unused by the team, and currently doesn't work if the setup is different from the devctr (see #5180).

How

The equivalent operation in the devtool is ./tools/devtool fmt.

Other information

We should keep the git-secrets check, moving it to the devtool if it's not already there.

@zulinx86 zulinx86 added the Status: WIP Indicates that an issue is currently being worked on or triaged label May 14, 2025
@Manciukic Manciukic linked a pull request May 21, 2025 that will close this issue
10 tasks
@roypat roypat linked a pull request May 28, 2025 that will close this issue
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: WIP Indicates that an issue is currently being worked on or triaged
Projects
None yet
2 participants