Skip to content

Commit ed2045b

Browse files
committed
test(perf): split block tests across two runners
This has two reasons: - When adding block latency tests (e.g. duplicating all existing test cases to also run with fio's sync workload generator), the runtime will exceed 1 hour, which is the buildkite pipeline timeout) - Having the sync and async cases in the same buildkite step means that the A/B-testing framework will try to cross-correct between the sync and async engine, but comparing results from these makes no sense because they are completely disjoint code paths in firecracker and the host kernel, so there is no reason to believe that their regressions should be correlated. Signed-off-by: Patrick Roy <[email protected]>
1 parent 316d955 commit ed2045b

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

.buildkite/pipeline_perf.py

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,14 @@
1616
# the operating system sometimes uses it for book-keeping tasks. The memory node (-m parameter)
1717
# has to be the node associated with the NUMA node from which we picked CPUs.
1818
perf_test = {
19-
"virtio-block": {
19+
"virtio-block-sync": {
2020
"label": "💿 Virtio Block Performance",
21-
"tests": "integration_tests/performance/test_block_ab.py::test_block_performance",
21+
"tests": "integration_tests/performance/test_block_ab.py::test_block_performance -k 'not Async'",
22+
"devtool_opts": "-c 1-10 -m 0",
23+
},
24+
"virtio-block-async": {
25+
"label": "💿 Virtio Block Performance",
26+
"tests": "integration_tests/performance/test_block_ab.py::test_block_performance -k Async",
2227
"devtool_opts": "-c 1-10 -m 0",
2328
},
2429
"vhost-user-block": {

0 commit comments

Comments
 (0)