feat(go): Add cancelAction and early trace ID to headers in go reflection server #3885
+668
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apascal07
reviewed
Dec 3, 2025
apascal07
reviewed
Dec 3, 2025
go/core/api/action.go
Outdated
| // RunJSONWithTelemetry runs the action with the given JSON input and streaming callback and returns the output as JSON along with telemetry info. | ||
| RunJSONWithTelemetry(ctx context.Context, input json.RawMessage, cb func(context.Context, json.RawMessage) error) (*ActionRunResult[json.RawMessage], error) | ||
| // The telemetryCb callback, if provided, is called as soon as the trace span is created with the trace ID and span ID. | ||
| RunJSONWithTelemetry(ctx context.Context, input json.RawMessage, cb func(context.Context, json.RawMessage) error, telemetryCb TelemetryCallback) (*ActionRunResult[json.RawMessage], error) |
Collaborator
There was a problem hiding this comment.
This is a breaking change...
Collaborator
There was a problem hiding this comment.
If I understand correctly, this is only used for reflection API? Can we pull that from the context instead so that this isn't a breaking change?
apascal07
reviewed
Dec 3, 2025
apascal07
reviewed
Dec 3, 2025
| Properties map[string]*Schema `json:"properties,omitempty"` | ||
| AdditionalProperties *Schema `json:"additionalProperties,omitempty"` | ||
| Const bool `json:"const,omitempty"` | ||
| Const any `json:"const,omitempty"` |
Collaborator
There was a problem hiding this comment.
Curious, what happened here?
Contributor
Author
There was a problem hiding this comment.
#3801 updates genkit-schema.json
const now can take string values, rather than bool values
So we need to update jsonschema.go to be able to generate updated schemas
apascal07
reviewed
Dec 3, 2025
apascal07
reviewed
Dec 3, 2025
apascal07
reviewed
Dec 4, 2025
apascal07
reviewed
Dec 4, 2025
apascal07
reviewed
Dec 4, 2025
Co-authored-by: Alex Pascal <[email protected]>
Co-authored-by: Alex Pascal <[email protected]>
…into jh-go-reflection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.