Skip to content

Commit ff334ac

Browse files
authored
fix(core): bump Firebase iOS SDK to 12.19.3 (4.x backport, Firestore security fix) (#18861)
* fix(core): bump Firebase iOS SDK to 12.19.3 (CocoaPods and SPM) for Firestore root-certificate security fix Backport to the 4.x line (BoM 4.20.0). firebase-ios-sdk#16930 removes compromised eMudhra CA roots from Firestore's embedded gRPC root-certificate bundle. Windows (C++ SDK) is covered in a follow-up firebase_core release. * fix(apple): resolve CocoaPods deps that skip the 12.19.3 patch release Firebase 12.19.3 only ships Core, Firestore and the umbrella pod. firebase_app_check (iOS) now depends on Firebase/AppCheck like macOS, and firebase_analytics allows any 12.19.x FirebaseAnalytics. * chore(firestore): drop precompiled Firestore frameworks from 4.x example Podfiles invertase/firestore-ios-sdk-frameworks has no 12.19.3 tag, so pod install failed; the examples now use the patched FirebaseFirestore from trunk.
1 parent e9f84d7 commit ff334ac

34 files changed

Lines changed: 34 additions & 36 deletions

File tree

‎packages/cloud_firestore/cloud_firestore/example/ios/Podfile‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,6 @@ target 'Runner' do
5050
raise "Error - unable to locate firebase_ios_sdk.rb script in firebase_core, and no FirebaseSDKVersion specified"
5151
end
5252
end
53-
54-
pod 'FirebaseFirestore', :git => 'https://github.com/invertase/firestore-ios-sdk-frameworks.git', :tag => "#{firebase_sdk_version}"
5553
end
5654

5755
post_install do |installer|

‎packages/cloud_firestore/cloud_firestore/example/macos/Podfile‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,6 @@ target 'Runner' do
4949
raise "Error - unable to locate firebase_ios_sdk.rb script in firebase_core, and no FirebaseSDKVersion specified"
5050
end
5151
end
52-
53-
pod 'FirebaseFirestore', :git => 'https://github.com/invertase/firestore-ios-sdk-frameworks.git', :tag => "#{firebase_sdk_version}"
5452
end
5553

5654
post_install do |installer|

‎packages/cloud_firestore/cloud_firestore/ios/cloud_firestore/Package.swift‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
import PackageDescription
99

1010
let libraryVersion = "6.10.0"
11-
let firebaseSdkVersion: Version = "12.19.0"
11+
let firebaseSdkVersion: Version = "12.19.3"
1212

1313
let package = Package(
1414
name: "cloud_firestore",

‎packages/cloud_firestore/cloud_firestore/macos/cloud_firestore/Package.swift‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
import PackageDescription
99

1010
let libraryVersion = "6.10.0"
11-
let firebaseSdkVersion: Version = "12.19.0"
11+
let firebaseSdkVersion: Version = "12.19.3"
1212

1313
let package = Package(
1414
name: "cloud_firestore",

‎packages/cloud_functions/cloud_functions/ios/cloud_functions/Package.swift‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
import PackageDescription
99

10-
let firebaseSdkVersion: Version = "12.19.0"
10+
let firebaseSdkVersion: Version = "12.19.3"
1111

1212
let package = Package(
1313
name: "cloud_functions",

‎packages/cloud_functions/cloud_functions/macos/cloud_functions/Package.swift‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
import PackageDescription
99

10-
let firebaseSdkVersion: Version = "12.19.0"
10+
let firebaseSdkVersion: Version = "12.19.3"
1111

1212
let package = Package(
1313
name: "cloud_functions",

‎packages/firebase_analytics/firebase_analytics/ios/firebase_analytics.podspec‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,8 @@ Pod::Spec.new do |s|
3838
s.swift_version = '5.0'
3939

4040
s.dependency 'firebase_core'
41-
s.dependency firebase_analytics, firebase_sdk_version
41+
# FirebaseAnalytics is not released with every Firebase patch version (e.g. 12.19.3), so allow any patch of the minor.
42+
s.dependency firebase_analytics, "~> #{firebase_sdk_version.sub(/\.\d+$/, '.0')}"
4243

4344
s.static_framework = true
4445
s.pod_target_xcconfig = {

‎packages/firebase_analytics/firebase_analytics/ios/firebase_analytics/Package.swift‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
import Foundation
99
import PackageDescription
1010

11-
let firebaseSdkVersion: Version = "12.19.0"
11+
let firebaseSdkVersion: Version = "12.19.3"
1212

1313
// Set FIREBASE_ANALYTICS_WITHOUT_ADID=true to use FirebaseAnalyticsCore.
1414
// e.g. FIREBASE_ANALYTICS_WITHOUT_ADID=true flutter build ios

‎packages/firebase_analytics/firebase_analytics/macos/firebase_analytics.podspec‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,8 @@ Pod::Spec.new do |s|
5959

6060
# Firebase dependencies
6161
s.dependency 'firebase_core'
62-
s.dependency firebase_analytics, firebase_sdk_version
62+
# FirebaseAnalytics is not released with every Firebase patch version (e.g. 12.19.3), so allow any patch of the minor.
63+
s.dependency firebase_analytics, "~> #{firebase_sdk_version.sub(/\.\d+$/, '.0')}"
6364

6465
s.static_framework = true
6566
s.pod_target_xcconfig = {

‎packages/firebase_analytics/firebase_analytics/macos/firebase_analytics/Package.swift‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
import PackageDescription
99

10-
let firebaseSdkVersion: Version = "12.19.0"
10+
let firebaseSdkVersion: Version = "12.19.3"
1111

1212
let package = Package(
1313
name: "firebase_analytics",

0 commit comments

Comments
 (0)