Skip to content

Commit c5c440c

Browse files
SelaseKayLyokone
authored andcommitted
fix(in_app_messaging,android): bump the example Gradle toolchain
The example could not assemble on current Flutter (Gradle 8.14 / AGP 8.11). Export in-app messaging artifacts as api so app Java compilation can resolve FirebaseInAppMessagingDisplay.
1 parent 3cb2270 commit c5c440c

5 files changed

Lines changed: 12 additions & 5 deletions

File tree

‎packages/firebase_in_app_messaging/firebase_in_app_messaging/android/build.gradle‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,10 @@ android {
7979
dependencies {
8080
api firebaseCoreProject
8181
implementation platform("com.google.firebase:firebase-bom:${getRootProjectExtOrCoreProperty("FirebaseSDKVersion", firebaseCoreProject)}")
82-
implementation 'com.google.firebase:firebase-inappmessaging-display'
82+
// `api` so app Java compilation can resolve FirebaseInAppMessagingDisplay,
83+
// which the plugin class implements.
84+
api 'com.google.firebase:firebase-inappmessaging'
85+
api 'com.google.firebase:firebase-inappmessaging-display'
8386
implementation 'androidx.annotation:annotation:1.7.0'
8487
}
8588
}

‎packages/firebase_in_app_messaging/firebase_in_app_messaging/example/android/app/build.gradle‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ android {
4141
applicationId = "io.flutter.plugins.firebase.tests"
4242
// You can update the following values to match your application needs.
4343
// For more information, see: https://docs.flutter.dev/deployment/android#reviewing-the-gradle-build-configuration.
44-
minSdk = 23
44+
minSdkVersion = flutter.minSdkVersion
4545
targetSdk = flutter.targetSdkVersion
4646
versionCode = flutterVersionCode.toInteger()
4747
versionName = flutterVersionName
Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,8 @@
11
org.gradle.jvmargs=-Xmx4G -XX:+HeapDumpOnOutOfMemoryError
22
android.useAndroidX=true
33
android.enableJetifier=true
4-
androidGradlePluginVersion=8.3.0
4+
androidGradlePluginVersion=8.11.1
5+
# This builtInKotlin flag was added automatically by Flutter migrator
6+
android.builtInKotlin=false
7+
# This newDsl flag was added automatically by Flutter migrator
8+
android.newDsl=false
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
distributionBase=GRADLE_USER_HOME
22
distributionPath=wrapper/dists
3-
distributionUrl=https\://services.gradle.org/distributions/gradle-8.4-bin.zip
3+
distributionUrl=https\://services.gradle.org/distributions/gradle-8.14-all.zip
44
zipStoreBase=GRADLE_USER_HOME
55
zipStorePath=wrapper/dists

‎packages/firebase_in_app_messaging/firebase_in_app_messaging/example/android/settings.gradle‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ pluginManagement {
1818

1919
plugins {
2020
id "dev.flutter.flutter-plugin-loader" version "1.0.0"
21-
id "com.android.application" version "${androidGradlePluginVersion}" apply false
21+
id "com.android.application" version "8.11.1" apply false
2222
// START: FlutterFire Configuration
2323
id "com.google.gms.google-services" version "4.3.15" apply false
2424
// END: FlutterFire Configuration

0 commit comments

Comments
 (0)