refactor!: android plugins require minSdk 21, auth requires minSdk 23 ahead of android BOM >=33.0.0 (#12873)

russellwheatley · web-flow · commit 52accfc6c39d · 2024-06-03T13:44:24.000+01:00
diff --git a/packages/cloud_firestore/cloud_firestore/android/build.gradle b/packages/cloud_firestore/cloud_firestore/android/build.gradle
@@ -43,7 +43,7 @@ android {
     compileSdk 34
 
     defaultConfig {
-        minSdk 19
+        minSdk 21
         testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
     }
 
diff --git a/packages/cloud_functions/cloud_functions/android/build.gradle b/packages/cloud_functions/cloud_functions/android/build.gradle
@@ -43,7 +43,7 @@ android {
   compileSdk 34
 
   defaultConfig {
-    minSdk 19
+    minSdk 21
     testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
   }
 
diff --git a/packages/firebase_analytics/firebase_analytics/android/build.gradle b/packages/firebase_analytics/firebase_analytics/android/build.gradle
@@ -43,7 +43,7 @@ android {
     compileSdk 34
 
     defaultConfig {
-        minSdk 19
+        minSdk 21
         testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
     }
 
diff --git a/packages/firebase_app_check/firebase_app_check/android/build.gradle b/packages/firebase_app_check/firebase_app_check/android/build.gradle
@@ -43,7 +43,7 @@ android {
   compileSdk 34
 
   defaultConfig {
-    minSdk 19
+    minSdk 21
     testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
   }
 
diff --git a/packages/firebase_app_installations/firebase_app_installations/android/build.gradle b/packages/firebase_app_installations/firebase_app_installations/android/build.gradle
@@ -43,7 +43,7 @@ android {
     compileSdk 34
 
     defaultConfig {
-        minSdk 19
+        minSdk 21
     }
 
     compileOptions {
diff --git a/packages/firebase_auth/firebase_auth/android/build.gradle b/packages/firebase_auth/firebase_auth/android/build.gradle
@@ -43,7 +43,7 @@ android {
     compileSdk 34
 
     defaultConfig {
-        minSdk 19
+        minSdk 23
         testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
     }
     compileOptions {
diff --git a/packages/firebase_core/firebase_core/android/build.gradle b/packages/firebase_core/firebase_core/android/build.gradle
@@ -29,7 +29,7 @@ android {
     compileSdk 34
 
     defaultConfig {
-        minSdk 19
+        minSdk 21
         testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
     }
 
diff --git a/packages/firebase_crashlytics/firebase_crashlytics/android/build.gradle b/packages/firebase_crashlytics/firebase_crashlytics/android/build.gradle
@@ -42,7 +42,7 @@ android {
   compileSdk 34
 
   defaultConfig {
-    minSdk 19
+    minSdk 21
     testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
   }
 
diff --git a/packages/firebase_database/firebase_database/android/build.gradle b/packages/firebase_database/firebase_database/android/build.gradle
@@ -43,7 +43,7 @@ android {
     compileSdk 34
 
     defaultConfig {
-        minSdk 19
+        minSdk 21
         testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
     }
 
diff --git a/packages/firebase_database/firebase_database/example/android/app/build.gradle b/packages/firebase_database/firebase_database/example/android/app/build.gradle
@@ -31,7 +31,7 @@ android {
 
   defaultConfig {
     applicationId 'io.flutter.plugins.firebase.database.example'
-    minSdk 19
+    minSdk 21
     targetSdk 33
     versionCode flutterVersionCode.toInteger()
     versionName flutterVersionName
diff --git a/packages/firebase_dynamic_links/firebase_dynamic_links/android/build.gradle b/packages/firebase_dynamic_links/firebase_dynamic_links/android/build.gradle
@@ -43,7 +43,7 @@ android {
   compileSdk 34
 
   defaultConfig {
-      minSdk 19
+      minSdk 21
       testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
   }
 
diff --git a/packages/firebase_dynamic_links/firebase_dynamic_links/example/android/app/build.gradle b/packages/firebase_dynamic_links/firebase_dynamic_links/example/android/app/build.gradle
@@ -31,7 +31,7 @@ android {
 
   defaultConfig {
     applicationId "io.flutter.plugins.firebase.dynamiclinksexample"
-    minSdk 19
+    minSdk 21
     targetSdk 33
     versionCode flutterVersionCode.toInteger()
     versionName flutterVersionName
diff --git a/packages/firebase_in_app_messaging/firebase_in_app_messaging/android/build.gradle b/packages/firebase_in_app_messaging/firebase_in_app_messaging/android/build.gradle
@@ -43,7 +43,7 @@ android {
     compileSdk 34
 
     defaultConfig {
-      minSdk 19
+      minSdk 21
       testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
     }
 
diff --git a/packages/firebase_messaging/firebase_messaging/android/build.gradle b/packages/firebase_messaging/firebase_messaging/android/build.gradle
@@ -43,7 +43,7 @@ android {
   compileSdk 34
 
   defaultConfig {
-    minSdk 19
+    minSdk 21
     testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
   }
 
diff --git a/packages/firebase_ml_model_downloader/firebase_ml_model_downloader/android/build.gradle b/packages/firebase_ml_model_downloader/firebase_ml_model_downloader/android/build.gradle
@@ -43,7 +43,7 @@ android {
   compileSdk 34
 
   defaultConfig {
-    minSdk 19
+    minSdk 21
     testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
   }
 
diff --git a/packages/firebase_performance/firebase_performance/android/build.gradle b/packages/firebase_performance/firebase_performance/android/build.gradle
@@ -43,7 +43,7 @@ android {
     compileSdk 34
 
     defaultConfig {
-        minSdk 19
+        minSdk 21
         testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
     }
 
diff --git a/packages/firebase_remote_config/firebase_remote_config/android/build.gradle b/packages/firebase_remote_config/firebase_remote_config/android/build.gradle
@@ -43,7 +43,7 @@ android {
     compileSdk 34
 
     defaultConfig {
-        minSdk 19
+        minSdk 21
         testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
     }
 
diff --git a/packages/firebase_storage/firebase_storage/android/build.gradle b/packages/firebase_storage/firebase_storage/android/build.gradle
@@ -51,7 +51,7 @@ android {
     compileSdk 34
 
     defaultConfig {
-        minSdk 19
+        minSdk 21
         testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
     }
 
diff --git a/tests/android/app/build.gradle b/tests/android/app/build.gradle
@@ -35,7 +35,8 @@ android {
 
     defaultConfig {
         applicationId = "io.flutter.plugins.firebase.tests"
-        minSdk = flutter.minSdkVersion
+        // auth requires minSdk 23
+        minSdk = 23
         targetSdk = 34
         versionCode = flutterVersionCode.toInteger()
         versionName = flutterVersionName

Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ android {`
`43`	`43`	`compileSdk 34`
`44`	`44`
`45`	`45`	`defaultConfig {`
`46`		`- minSdk 19`
	`46`	`+ minSdk 21`
`47`	`47`	`testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"`
`48`	`48`	`}`
`49`	`49`
Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ android {`
`29`	`29`	`compileSdk 34`
`30`	`30`
`31`	`31`	`defaultConfig {`
`32`		`- minSdk 19`
	`32`	`+ minSdk 21`
`33`	`33`	`testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"`
`34`	`34`	`}`
`35`	`35`
Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ android {`
`42`	`42`	`compileSdk 34`
`43`	`43`
`44`	`44`	`defaultConfig {`
`45`		`- minSdk 19`
	`45`	`+ minSdk 21`
`46`	`46`	`testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"`
`47`	`47`	`}`
`48`	`48`
Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ android {`
`51`	`51`	`compileSdk 34`
`52`	`52`
`53`	`53`	`defaultConfig {`
`54`		`- minSdk 19`
	`54`	`+ minSdk 21`
`55`	`55`	`testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"`
`56`	`56`	`}`
`57`	`57`