fix(database): fix #81 - setPersistenceCacheSizeBytes call on Android

Author: Ehesp

packages/firebase_database/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 3.1.5
+
+* Fix (#81) Android setPersistenceCacheSizeBytes crash when Long value was provided.
+
 ## 3.1.4
 
 * Fix for missing UserAgent.h compilation failures.

packages/firebase_database/android/src/main/java/io/flutter/plugins/firebase/database/MethodCallHandlerImpl.java

@@ -272,9 +272,17 @@ public void onMethodCall(final MethodCall call, @NonNull final MethodChannel.Res
 
       case "FirebaseDatabase#setPersistenceCacheSizeBytes":
         {
-          Long cacheSize = call.argument("cacheSize");
+          Object value = call.argument("cacheSize");
+          Long cacheSizeBytes = 10485760L; // 10mb default
+
+          if (value instanceof Long) {
+            cacheSizeBytes = (Long) value;
+          } else if (value instanceof Integer) {
+            cacheSizeBytes = Long.valueOf((Integer) value);
+          }
+
           try {
-            database.setPersistenceCacheSizeBytes(cacheSize);
+            database.setPersistenceCacheSizeBytes(cacheSizeBytes);
             result.success(true);
           } catch (DatabaseException e) {
             // Database is already in use, e.g. after hot reload/restart.

packages/firebase_database/example/test_driver/firebase_database_e2e.dart

@@ -20,5 +20,15 @@ void main() {
       expect(transactionResult.committed, true);
       expect(transactionResult.dataSnapshot.value > value, true);
     });
+
+    testWidgets('setPersistenceCacheSizeBytes Integer',
+        (WidgetTester tester) async {
+      await database.setPersistenceCacheSizeBytes(2147483647);
+    });
+
+    testWidgets('setPersistenceCacheSizeBytes Long',
+        (WidgetTester tester) async {
+      await database.setPersistenceCacheSizeBytes(2147483648);
+    });
   });
 }

packages/firebase_database/pubspec.yaml

@@ -2,7 +2,7 @@ name: firebase_database
 description: Flutter plugin for Firebase Database, a cloud-hosted NoSQL database
   with realtime data syncing across Android and iOS clients, and offline access.
 homepage: https://github.com/FirebaseExtended/flutterfire/tree/master/packages/firebase_database
-version: 3.1.4
+version: 3.1.5
 
 flutter:
   plugin: