test(database): fix tests that were failing frequently on web e2e test run (#12857)

Author: russellwheatley

.github/workflows/scripts/database.rules.json

@@ -27,6 +27,11 @@
         ".indexOn": [
           "value"
         ]
+      },
+      "children": {
+        ".read": true,
+        ".write": true,
+        ".indexOn": [".value"]
       }
     }
   }

tests/integration_test/firebase_database/data_snapshot_e2e.dart

@@ -8,6 +8,9 @@ import 'package:flutter_test/flutter_test.dart';
 void setupDataSnapshotTests() {
   group('DataSnapshot', () {
     late DatabaseReference ref;
+    DatabaseReference getRef(String path) {
+      return FirebaseDatabase.instance.ref('tests').child(path);
+    }
 
     setUp(() async {
       ref = FirebaseDatabase.instance.ref('tests');
@@ -17,35 +20,41 @@ void setupDataSnapshotTests() {
     });
 
     test('it returns the correct key', () async {
+      final ref = getRef('key');
       final s = await ref.get();
-      expect(s.key, 'tests');
+      expect(s.key, 'key');
     });
 
     test('it returns a string value', () async {
+      final ref = getRef('string');
       await ref.set('foo');
       final s = await ref.get();
       expect(s.value, 'foo');
     });
 
     test('it returns a number value', () async {
+      final ref = getRef('num');
       await ref.set(123);
       final s = await ref.get();
       expect(s.value, 123);
     });
 
     test('it returns a bool value', () async {
+      final ref = getRef('bool');
       await ref.set(false);
       final s = await ref.get();
       expect(s.value, false);
     });
 
     test('it returns a null value', () async {
+      final ref = getRef('null');
       await ref.set(null);
       final s = await ref.get();
       expect(s.value, isNull);
     });
 
     test('it returns a List value', () async {
+      final ref = getRef('list');
       final data = [
         'a',
         2,
@@ -71,49 +80,58 @@ void setupDataSnapshotTests() {
     });
 
     test('it returns a Map value', () async {
+      final ref = getRef('map');
       final data = {'foo': 'bar'};
+
       await ref.set(data);
       final s = await ref.get();
       expect(s.value, equals(data));
     });
 
     test('non-string Map keys are converted to strings', () async {
+      final ref = getRef('converted');
       final data = {1: 'foo', 2: 'bar', 'foo': 'bar'};
       await ref.set(data);
       final s = await ref.get();
       expect(s.value, equals({'1': 'foo', '2': 'bar', 'foo': 'bar'}));
     });
 
     test('setWithPriority returns the correct priority', () async {
+      final ref = getRef('priority');
       await ref.setWithPriority('foo', 1);
       final s = await ref.get();
       expect(s.priority, 1);
     });
 
     test('setPriority returns the correct priority', () async {
+      final ref = getRef('priority-2');
       await ref.set('foo');
       await ref.setPriority(2);
       final s = await ref.get();
       expect(s.priority, 2);
     });
 
     test('exists returns true', () async {
+      final ref = getRef('exists');
       await ref.set('foo');
       final s = await ref.get();
       expect(s.exists, isTrue);
     });
 
     test('exists returns false', () async {
+      final ref = getRef('exists-not-here');
       final s = await ref.get();
       expect(s.exists, isFalse);
     });
 
     test('hasChild returns false', () async {
+      final ref = getRef('has-child');
       final s = await ref.get();
       expect(s.hasChild('bar'), isFalse);
     });
 
     test('hasChild returns true', () async {
+      final ref = getRef('has-no-child');
       await ref.set({
         'foo': {'bar': 'baz'},
       });
@@ -122,13 +140,15 @@ void setupDataSnapshotTests() {
     });
 
     test('child returns the correct snapshot for lists', () async {
+      final ref = getRef('list-snap');
       await ref.set([0, 1]);
       final s = await ref.get();
       expect(s.child('1'), isA<DataSnapshot>());
       expect(s.child('1').value, 1);
     });
 
     test('child returns the correct snapshot', () async {
+      final ref = getRef('child-snap');
       await ref.set({
         'foo': {'bar': 'baz'},
       });
@@ -138,6 +158,7 @@ void setupDataSnapshotTests() {
     });
 
     test('children returns the children in order', () async {
+      final ref = getRef('children');
       await ref.set({
         'a': 3,
         'b': 2,

tests/integration_test/firebase_database/query_e2e.dart

@@ -432,14 +432,22 @@ void setupQueryTests() {
     });
 
     group('onChildChanged', () {
+      // Create own reference as this clashed with previous tests on web platform
+      late DatabaseReference childRef;
+      setUp(() async {
+        childRef = FirebaseDatabase.instance.ref('tests').child('child-ref');
+        // Wipe the database before each test
+        await childRef.remove();
+      });
+
       test(
         'emits an event when a child is changed',
         () async {
-          await ref.child('foo').set('foo');
-          await ref.child('bar').set('bar');
+          await childRef.child('foo').set('foo');
+          await childRef.child('bar').set('bar');
 
           expect(
-            ref.onChildChanged,
+            childRef.onChildChanged,
             emitsInOrder([
               isA<DatabaseEvent>()
                   .having((s) => s.snapshot.key, 'key', 'bar')
@@ -462,8 +470,8 @@ void setupQueryTests() {
           // Give time for listen to be registered on native.
           // TODO is there a better way to do this?
           await Future.delayed(const Duration(seconds: 1));
-          await ref.child('bar').set('baz');
-          await ref.child('foo').set('bar');
+          await childRef.child('bar').set('baz');
+          await childRef.child('foo').set('bar');
         },
         retry: 2,
       );