Skip to content

Commit 3acab7d

Browse files
authored
ci(auth): run iOS e2e on CocoaPods until GoogleSignIn supports App Check 12
Firebase Apple SDK 13 requires app-check 12 under Swift Package Manager, and every GoogleSignIn-iOS release still requires app-check 11, so the auth example cannot resolve its packages under SPM.
1 parent 6b963dd commit 3acab7d

3 files changed

Lines changed: 8 additions & 2 deletions

File tree

‎.github/workflows/e2e_tests_auth.yaml‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,12 @@ jobs:
8686
# FIRInstallations aborts on at launch.
8787
native-config-args: '--live-tier-plist=auth'
8888
inject-config-secrets: true
89+
# Firebase Apple SDK 13 needs app-check 12, and every GoogleSignIn-iOS
90+
# release (8.0.0 to 10.0.0) needs app-check 11, so the example's
91+
# google_sign_in cannot resolve under SPM. CocoaPods is still on 12.19.0.
92+
# Rejoin SPM once https://github.com/google/GoogleSignIn-iOS/pull/626
93+
# ships and google_sign_in_ios accepts that release.
94+
ios-spm: false
8995
nightly_test_mode: ${{ inputs.nightly_test_mode == true }}
9096
secrets:
9197
TESTS_E2E_FIREBASE_OPTIONS_DART: ${{ secrets.TESTS_E2E_FIREBASE_OPTIONS_DART }}

‎.github/workflows/e2e_tests_functions.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ jobs:
7272
# 26.2 pin (see `reusable_e2e_ios.yaml`) is the likely fix, but one
7373
# variable at a time - these two rejoin SPM once the default-Xcode runs
7474
# prove clean. iOS SPM coverage is unaffected meanwhile: storage,
75-
# database, firestore and auth still build under it.
75+
# database and firestore still build under it.
7676
ios-spm: false
7777
native-config-args: '--functions-native'
7878
nightly_test_mode: ${{ inputs.nightly_test_mode == true }}

‎.github/workflows/e2e_tests_performance.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ jobs:
8585
# 26.2 pin (see `reusable_e2e_ios.yaml`) is the likely fix, but one
8686
# variable at a time - these two rejoin SPM once the default-Xcode runs
8787
# prove clean. iOS SPM coverage is unaffected meanwhile: storage,
88-
# database, firestore and auth still build under it.
88+
# database and firestore still build under it.
8989
ios-spm: false
9090
native-config-args: '--live-tier-plist=performance'
9191
inject-config-secrets: true

0 commit comments

Comments
 (0)