Skip to content

Commit f581d23

Browse files
committed
Removed unnecessary types
1 parent 0800a8b commit f581d23

File tree

4 files changed

+7
-15
lines changed

4 files changed

+7
-15
lines changed

common/api-review/data-connect.api.md

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,9 @@
44
55
```ts
66

7-
import { AppCheckInternalComponentName } from '@firebase/app-check-interop-types';
87
import { FirebaseApp } from '@firebase/app';
9-
import { FirebaseAuthInternalName } from '@firebase/auth-interop-types';
108
import { FirebaseError } from '@firebase/util';
119
import { LogLevelString } from '@firebase/logger';
12-
import { Provider } from '@firebase/component';
1310

1411
// @public
1512
export type CallerSdkType = 'Base' | 'Generated' | 'TanstackReactCore' | 'GeneratedReact' | 'TanstackAngularCore' | 'GeneratedAngular';
@@ -53,7 +50,6 @@ export interface ConnectorConfig {
5350

5451
// @public
5552
export class DataConnect {
56-
constructor(app: FirebaseApp, dataConnectOptions: DataConnectOptions, _authProvider: Provider<FirebaseAuthInternalName>, _appCheckProvider: Provider<AppCheckInternalComponentName>);
5753
// (undocumented)
5854
readonly app: FirebaseApp;
5955
// (undocumented)
@@ -97,12 +93,6 @@ export interface DataConnectOperationFailureResponseErrorInfo {
9793
readonly path: Array<string | number>;
9894
}
9995

100-
// @public
101-
export interface DataConnectOptions extends ConnectorConfig {
102-
// (undocumented)
103-
projectId: string;
104-
}
105-
10696
// @public (undocumented)
10797
export interface DataConnectResult<Data, Variables> extends OpResult<Data> {
10898
// (undocumented)
@@ -216,7 +206,7 @@ export type ReferenceType = typeof QUERY_STR | typeof MUTATION_STR;
216206
// @public
217207
export interface RefInfo<Variables> {
218208
// (undocumented)
219-
connectorConfig: DataConnectOptions;
209+
connectorConfig: ConnectorConfig;
220210
// (undocumented)
221211
name: string;
222212
// (undocumented)

packages/data-connect/src/api/DataConnect.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,9 @@ export class DataConnect {
104104
_isUsingGeneratedSdk: boolean = false;
105105
_callerSdkType: CallerSdkType = CallerSdkTypeEnum.Base;
106106
private _appCheckTokenProvider?: AppCheckTokenProvider;
107-
// @internal
107+
/**
108+
* @hideconstructor
109+
*/
108110
constructor(
109111
public readonly app: FirebaseApp,
110112
// TODO(mtewani): Replace with _dataConnectOptions in the future

packages/data-connect/src/api/Reference.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
* limitations under the License.
1616
*/
1717

18-
import { DataConnect, DataConnectOptions } from './DataConnect';
18+
import { ConnectorConfig, DataConnect } from './DataConnect';
1919
export const QUERY_STR = 'query';
2020
export const MUTATION_STR = 'mutation';
2121
export type ReferenceType = typeof QUERY_STR | typeof MUTATION_STR;
@@ -48,7 +48,7 @@ export interface DataConnectResult<Data, Variables> extends OpResult<Data> {
4848
export interface RefInfo<Variables> {
4949
name: string;
5050
variables: Variables;
51-
connectorConfig: DataConnectOptions;
51+
connectorConfig: ConnectorConfig;
5252
}
5353
/**
5454
* Serialized Ref as a result of `QueryResult.toJSON()`

packages/data-connect/src/api/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
*/
1717

1818
export * from '../network';
19-
export * from './DataConnect';
19+
export { ConnectorConfig, DataConnect, TransportOptions, areTransportOptionsEqual, connectDataConnectEmulator, getDataConnect, parseOptions, terminate, validateDCOptions } from './DataConnect';
2020
export * from './Reference';
2121
export * from './Mutation';
2222
export * from './query';

0 commit comments

Comments
 (0)