Skip to content

Commit 1c79ea6

Browse files
authored
Fix #136 (#141)
* Fix #136 This commit fixes a breaking issue with the test sdk. Exports won't function properly with functions annotated with @internal. Which, was a little unexpected... but here we are. :) * Update main to not export the private methods
1 parent 948334a commit 1c79ea6

File tree

4 files changed

+4
-6
lines changed

4 files changed

+4
-6
lines changed

spec/main.spec.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,12 @@ import { set } from 'lodash';
2727
import {
2828
mockConfig,
2929
makeChange,
30-
_makeResourceName,
31-
_extractParams,
3230
wrap,
3331
} from '../src/main';
32+
import {
33+
_makeResourceName,
34+
_extractParams,
35+
} from '../src/v1';
3436
import { features } from '../src/features';
3537
import { FirebaseFunctionsTest } from '../src/lifecycle';
3638
import { alerts } from 'firebase-functions/v2';

src/cloudevent/generate.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ export function generateCombinedCloudEvent<
2020
: generatedCloudEvent;
2121
}
2222

23-
/** @internal */
2423
export function generateMockCloudEvent<EventType extends CloudEvent<unknown>>(
2524
cloudFunction: CloudFunction<EventType>
2625
): EventType {

src/cloudevent/partials/partials.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ import { pubsubOnMessagePublished } from './pubsub/pubsub-on-message-published';
1414
import { storageV1 } from './storage';
1515

1616
/**
17-
* @internal
1817
* Note: Ordering matters. Some MockEventPartials will match more generally
1918
* (eg {@link alertsOnAlertPublished}). In addition,
2019
* {@link eventarcOnCustomEventPublished} acts as a catch-all.

src/main.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,6 @@ export {
4040
CallableContextOptions,
4141
makeChange,
4242
mockConfig,
43-
_makeResourceName,
44-
_extractParams,
4543
} from './v1';
4644

4745
// V2 Exports

0 commit comments

Comments
 (0)