Skip to content

Commit eb42a24

Browse files
chkuang-ga-maurice
authored andcommitted
Use LogMessageWithCallbackV() for SystemLogger
So that all logger can use specified log function like Unity Log functions. PiperOrigin-RevId: 267505161
1 parent b58abff commit eb42a24

File tree

3 files changed

+7
-4
lines changed

3 files changed

+7
-4
lines changed

app/src/log.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -126,8 +126,8 @@ static void LogToFile(LogLevel log_level, const char* format, va_list args) {
126126
#endif // FIREBASE_LOG_TO_FILE
127127

128128
// Log a firebase message (implemented by the platform specific logger).
129-
static void LogMessageWithCallbackV(LogLevel log_level, const char* format,
130-
va_list args) {
129+
void LogMessageWithCallbackV(LogLevel log_level, const char* format,
130+
va_list args) {
131131
// We create the mutex on the heap as this can be called before the C++
132132
// runtime is initialized on iOS. This ensures the Mutex class is
133133
// constructed before we attempt to use it. Of course, this isn't thread

app/src/log.h

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,11 @@ void LogError(const char* format, ...);
5555
void LogAssert(const char* format, ...);
5656
// Log a firebase message (implemented by the platform specific logger).
5757
void LogMessageV(LogLevel log_level, const char* format, va_list args);
58-
// Log a firebase message via LogMessageV().
58+
// Log a firebase message via LogMessageWithCallbackV().
5959
void LogMessage(LogLevel log_level, const char* format, ...);
60+
// Log a firebase message through log callback.
61+
void LogMessageWithCallbackV(LogLevel log_level, const char* format,
62+
va_list args);
6063

6164
// Callback which can be used to override message logging.
6265
typedef void (*LogCallback)(LogLevel log_level, const char* log_message,

app/src/logger.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ LogLevel SystemLogger::GetLogLevel() const {
8686

8787
void SystemLogger::LogMessageImplV(LogLevel log_level, const char* format,
8888
va_list args) const {
89-
::FIREBASE_NAMESPACE::LogMessageV(log_level, format, args);
89+
::FIREBASE_NAMESPACE::LogMessageWithCallbackV(log_level, format, args);
9090
}
9191

9292
Logger::~Logger() {}

0 commit comments

Comments
 (0)