Skip to content

Commit af5fb6e

Browse files
Googlera-maurice
authored andcommitted
Quash -Wmove triggers
Fix code that triggers -Wmove, which isn’t an error today but will be soon. See the referenced bug for full context. Tested: TAP --sample ran all affected tests and none failed http://test/OCL:267146993:BASE:267126309:1567606504088:33870910 PiperOrigin-RevId: 267177351
1 parent 49fa759 commit af5fb6e

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

functions/src/ios/callable_reference_ios.mm

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ Error NSErrorToErrorCode(NSError* error) {
127127

128128
Future<HttpsCallableResult> HttpsCallableReferenceInternal::Call() {
129129
ReferenceCountedFutureImpl* future_impl = future();
130-
HttpsCallableResult null_result(std::move(Variant::Null()));
130+
HttpsCallableResult null_result(Variant::Null());
131131
SafeFutureHandle<HttpsCallableResult> handle =
132132
future_impl->SafeAlloc(kCallableReferenceFnCall, null_result);
133133
void (^completion)(FIRHTTPSCallableResult* _Nullable, NSError* _Nullable) =
@@ -143,7 +143,7 @@ Error NSErrorToErrorCode(NSError* error) {
143143
id data = util::VariantToId(variant);
144144

145145
ReferenceCountedFutureImpl* future_impl = future();
146-
HttpsCallableResult null_result(std::move(Variant::Null()));
146+
HttpsCallableResult null_result(Variant::Null());
147147
SafeFutureHandle<HttpsCallableResult> handle =
148148
future_impl->SafeAlloc(kCallableReferenceFnCall, null_result);
149149
void (^completion)(FIRHTTPSCallableResult* _Nullable, NSError* _Nullable) =

0 commit comments

Comments
 (0)