Offline Auth method picker (#1586)

Author: samtstern

auth/build.gradle.kts

@@ -13,6 +13,7 @@ android {
         disable("UnusedQuantity")
         disable("UnknownNullness")  // TODO fix in future PR
         disable("TypographyQuotes") // Straight versus directional quotes
+        disable("MissingTranslation") // STOPSHIP: Get translations
     }
 
     testOptions {

auth/src/main/java/com/firebase/ui/auth/KickoffActivity.java

@@ -3,7 +3,6 @@
 import android.arch.lifecycle.ViewModelProviders;
 import android.content.Context;
 import android.content.Intent;
-import android.net.ConnectivityManager;
 import android.os.Bundle;
 import android.support.annotation.NonNull;
 import android.support.annotation.Nullable;
@@ -62,12 +61,7 @@ public void onSuccess(Void aVoid) {
                             return;
                         }
 
-                        if (isOffline()) {
-                            finish(RESULT_CANCELED, IdpResponse.getErrorIntent(
-                                    new FirebaseUiException(ErrorCodes.NO_NETWORK)));
-                        } else {
-                            mKickstarter.start();
-                        }
+                        mKickstarter.start();
                     }
                 })
                 .addOnFailureListener(this, new OnFailureListener() {
@@ -98,18 +92,4 @@ public void invalidateEmailLink() {
         setIntent(getIntent().putExtra(ExtraConstants.FLOW_PARAMS,
                 flowParameters));
     }
-
-    /**
-     * Check if there is an active or soon-to-be-active network connection.
-     *
-     * @return true if there is no network connection, false otherwise.
-     */
-    private boolean isOffline() {
-        ConnectivityManager manager = (ConnectivityManager) getApplicationContext()
-                .getSystemService(Context.CONNECTIVITY_SERVICE);
-
-        return !(manager != null
-                && manager.getActiveNetworkInfo() != null
-                && manager.getActiveNetworkInfo().isConnectedOrConnecting());
-    }
 }

auth/src/main/java/com/firebase/ui/auth/ui/HelperActivityBase.java

@@ -3,6 +3,7 @@
 import android.app.Activity;
 import android.content.Context;
 import android.content.Intent;
+import android.net.ConnectivityManager;
 import android.support.annotation.NonNull;
 import android.support.annotation.Nullable;
 import android.support.annotation.RestrictTo;
@@ -75,4 +76,18 @@ public void startSaveCredentials(
                 this, getFlowParams(), credential, response);
         startActivityForResult(intent, RequestCodes.CRED_SAVE_FLOW);
     }
+
+    /**
+     * Check if there is an active or soon-to-be-active network connection.
+     *
+     * @return true if there is no network connection, false otherwise.
+     */
+    protected boolean isOffline() {
+        ConnectivityManager manager = (ConnectivityManager) getApplicationContext()
+                .getSystemService(Context.CONNECTIVITY_SERVICE);
+
+        return !(manager != null
+                && manager.getActiveNetworkInfo() != null
+                && manager.getActiveNetworkInfo().isConnectedOrConnecting());
+    }
 }

auth/src/main/java/com/firebase/ui/auth/ui/idp/AuthMethodPickerActivity.java

@@ -307,6 +307,11 @@ private void handleResponse(@NonNull IdpResponse response) {
         view.setOnClickListener(new View.OnClickListener() {
             @Override
             public void onClick(View view) {
+                if (isOffline()) {
+                    Toast.makeText(AuthMethodPickerActivity.this, getString(R.string.fui_no_internet), Toast.LENGTH_SHORT).show();
+                    return;
+                }
+
                 provider.startSignIn(AuthMethodPickerActivity.this);
             }
         });

auth/src/main/res/values/strings.xml

@@ -9,6 +9,7 @@
     <string name="fui_continue" translation_description="Button text to continue">Continue</string>
     <string name="fui_tos_and_pp" translation_description="Global ToS and privacy policy message">By continuing, you are indicating that you accept our <xliff:g example="https://google.com/terms" id="tos" translation_description="Terms of service text">%1$s</xliff:g> and <xliff:g example="https://google.com/privacy" id="pp" translation_description="Privacy policy text">%2$s</xliff:g>.</string>
     <string name="fui_tos_and_pp_footer" translation_description="Global ToS and Privacy policy footer"><xliff:g example="https://google.com/terms" id="tos" translation_description="Footer ToS text">%1$s</xliff:g> \u00A0 \u00A0 <xliff:g example="https://google.com/privacy" id="pp" translation_description="Footer privacy policy text">%2$s</xliff:g></string>
+    <string name="fui_no_internet" translation_descripition="User message shown when sign-in is attempted while offline.">Network error, check your internet connection.</string>
 
     <!-- Provider -->
     <string name="fui_idp_name_google">Google</string>