Skip to content

Commit 9b3b3a3

Browse files
authored
Fix bad merge (#1960)
1 parent 1e8b737 commit 9b3b3a3

File tree

1 file changed

+16
-29
lines changed

1 file changed

+16
-29
lines changed

app/src/main/java/com/firebase/uidemo/auth/AnonymousUpgradeActivity.java

Lines changed: 16 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,6 @@ public class AnonymousUpgradeActivity extends AppCompatActivity
3535

3636
private static final String TAG = "AccountLink";
3737

38-
private static final int RC_SIGN_IN = 123;
39-
4038
private ActivityAnonymousUpgradeBinding mBinding;
4139

4240
private AuthCredential mPendingCredential;
@@ -152,33 +150,22 @@ public void onComplete(@NonNull Task<Void> task) {
152150
});
153151
}
154152

155-
@Override
156-
protected void onActivityResult(int requestCode, int resultCode, @Nullable Intent data) {
157-
super.onActivityResult(requestCode, resultCode, data);
158-
handleSignInResult(requestCode, resultCode, data);
159-
}
160-
161-
private void handleSignInResult(int requestCode, int resultCode, Intent data) {
162-
if (requestCode == RC_SIGN_IN) {
163-
IdpResponse response = IdpResponse.fromResultIntent(data);
164-
if (response == null) {
165-
// User pressed back button
166-
return;
167-
}
168-
if (resultCode == RESULT_OK) {
169-
setStatus("Signed in as " + getUserIdentifier(FirebaseAuth.getInstance()
170-
.getCurrentUser()));
171-
} else if (response.getError().getErrorCode() == ErrorCodes
172-
.ANONYMOUS_UPGRADE_MERGE_CONFLICT) {
173-
setStatus("Merge conflict: user already exists.");
174-
mBinding.resolveMerge.setEnabled(true);
175-
mPendingCredential = response.getCredentialForLinking();
176-
} else {
177-
Toast.makeText(this, "Auth error, see logs", Toast.LENGTH_SHORT).show();
178-
Log.w(TAG, "Error: " + response.getError().getMessage(), response.getError());
179-
}
180-
181-
updateUI();
153+
private void handleSignInResult(int resultCode, @Nullable IdpResponse response) {
154+
if (response == null) {
155+
// User pressed back button
156+
return;
157+
}
158+
if (resultCode == RESULT_OK) {
159+
setStatus("Signed in as " + getUserIdentifier(FirebaseAuth.getInstance()
160+
.getCurrentUser()));
161+
} else if (response.getError().getErrorCode() == ErrorCodes
162+
.ANONYMOUS_UPGRADE_MERGE_CONFLICT) {
163+
setStatus("Merge conflict: user already exists.");
164+
mBinding.resolveMerge.setEnabled(true);
165+
mPendingCredential = response.getCredentialForLinking();
166+
} else {
167+
Toast.makeText(this, "Auth error, see logs", Toast.LENGTH_SHORT).show();
168+
Log.w(TAG, "Error: " + response.getError().getMessage(), response.getError());
182169
}
183170

184171
updateUI();

0 commit comments

Comments
 (0)