Skip to content

Commit ec68e4f

Browse files
author
Gayathri
committed
fix tests
1 parent c55a339 commit ec68e4f

File tree

4 files changed

+6
-5
lines changed

4 files changed

+6
-5
lines changed

legend-sdlc-server/src/test/java/org/finos/legend/sdlc/server/gitlab/api/GitLabPatchApiTestResource.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -72,10 +72,10 @@ public void runCreatePatchTest() throws LegendSDLCServerException
7272

7373
public void runGetPatchTest() throws LegendSDLCServerException
7474
{
75-
String projectName = "PatchTestProjectOne";
75+
String projectName = "PatchTestProjectThree";
7676
String description = "A test project.";
7777
String groupId = "org.finos.sdlc.test";
78-
String artifactId = "testpatchprojone";
78+
String artifactId = "testpatchprojthree";
7979
List<String> tags = Lists.mutable.with("doe", "moffitt", AbstractGitLabServerApiTest.INTEGRATION_TEST_PROJECT_TAG);
8080

8181
Project createdProject = gitLabProjectApi.createProject(projectName, description, ProjectType.MANAGED, groupId, artifactId, tags);
@@ -94,7 +94,7 @@ public void runGetPatchTest() throws LegendSDLCServerException
9494
Assert.assertEquals(projectId, patch.getProjectId());
9595
Assert.assertEquals("0.0.2", patch.getPatchReleaseVersionId().toVersionIdString());
9696

97-
Patch returnedPatch = gitLabPatchApi.getPatch(projectId, version.getId());
97+
Patch returnedPatch = gitLabPatchApi.getPatch(projectId, patch.getPatchReleaseVersionId());
9898
Assert.assertNotNull(returnedPatch);
9999
Assert.assertEquals(projectId, returnedPatch.getProjectId());
100100
Assert.assertEquals("0.0.2", returnedPatch.getPatchReleaseVersionId().toVersionIdString());

legend-sdlc-server/src/test/java/org/finos/legend/sdlc/server/inmemory/backend/InMemoryMixins.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,8 @@ public abstract class Project
4141
include = JsonTypeInfo.As.PROPERTY,
4242
property = "jackson-type")
4343
@JsonSubTypes({
44-
@JsonSubTypes.Type(value = InMemoryWorkspace.class, name = "InMemoryWorkspace")})
44+
@JsonSubTypes.Type(value = InMemoryWorkspace.class, name = "InMemoryWorkspace"),
45+
@JsonSubTypes.Type(value = InMemoryWorkspace.class, name = "InMemoryReview$1")})
4546
public abstract class Workspace
4647
{
4748

legend-sdlc-server/src/test/java/org/finos/legend/sdlc/server/inmemory/domain/api/InMemoryWorkspace.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ public class InMemoryWorkspace implements Workspace
3131
private String currentRevisionId;
3232
private String projectId;
3333
private String workspaceId;
34-
private DevelopmentStreamType sourceType;
3534
private DevelopmentStream source;
3635

3736
@Inject

legend-sdlc-server/src/test/java/org/finos/legend/sdlc/server/resources/TestPatchesResource.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ public void testGetPatch() throws HttpResponseException
4646

4747
Assert.assertEquals("1.0.1", patch.getPatchReleaseVersionId().toVersionIdString());
4848
}
49+
4950
@Test
5051
public void testGetAllPatches() throws HttpResponseException
5152
{

0 commit comments

Comments
 (0)