Legend SQL -> minor cleanups/optimisations (#3431)

TDS2Relation -> fail on any unsupported tds function with nice error

Author: gs-jp1

legend-engine-core/legend-engine-core-pure/legend-engine-pure-code-compiled-core/src/main/resources/core/pure/tds/relation/tdsToRelation.pure

@@ -51,6 +51,9 @@ function meta::pure::tds::toRelation::transform(v:meta::protocols::pure::vX_X_X:
 
 function meta::pure::tds::toRelation::transform(a:AppliedFunction[1], extensions:Extension[*]):AppliedFunction[1]
 {
+
+  let func = resolveFControlFunction($a, $extensions);
+
   [
     pair(project_T_MANY__ColumnSpecification_MANY__TabularDataSet_1_->cast(@Function<Any>),
       |
@@ -226,26 +229,32 @@ function meta::pure::tds::toRelation::transform(a:AppliedFunction[1], extensions
       swap(take_TabularDataSet_1__Integer_1__TabularDataSet_1_, limit_Relation_1__Integer_1__Relation_1_, $a, $extensions),
       swap(distinct_TabularDataSet_1__TabularDataSet_1_, distinct_Relation_1__Relation_1_, $a, $extensions),
       swap(concatenate_TabularDataSet_1__TabularDataSet_1__TabularDataSet_1_, concatenate_Relation_1__Relation_1__Relation_1_, $a, $extensions)
-    ])->concatenate(getExtensions($a, $extensions))->getValue(resolveFControlFunction($a, $extensions), | ^$a(parameters = $a.parameters->map(p | $p->transform($extensions))))->eval();
+    ])->concatenate(getExtensions($a, $extensions))->getValue($func, | defaultTransform($func, $a, $extensions))->eval();
 }
 
+
+
 function meta::pure::tds::toRelation::getExtensions(a:AppliedFunction[1], extensions:Extension[*]):meta::pure::functions::collection::Pair<Function<Any>, FunctionDefinition<{->AppliedFunction[1]}>>[*]
 {
   $extensions.tdsToRelation
     ->filter(t | $t->instanceOf(TdsToRelationExtension_V_X_X))
     ->cast(@TdsToRelationExtension_V_X_X).transfers->map(t | $t->eval($a, $extensions))
 }
 
+function meta::pure::tds::toRelation::defaultTransform(f:Function<Any>[1], a:AppliedFunction[1], extensions:Extension[*]):AppliedFunction[1]
+{
+  let returnType = $f->functionReturnType().rawType;
 
+  assert(!($returnType->isNotEmpty() && $returnType->toOne()->subTypeOf(TabularDataSet)), 'conversion of function "' + $f.name->toOne() + '"" is currently not supported');
 
-function meta::pure::tds::toRelation::swap(f:Function<Any>[1], o:Function<Any>[1], a:AppliedFunction[1], extensions:Extension[*]):meta::pure::functions::collection::Pair<Function<Any>, FunctionDefinition<{->AppliedFunction[1]}>>[1]
-{
-  pair($f, | appliedFunction($o, $a.parameters->map(p | $p->transform($extensions))))
+  ^$a(parameters = $a.parameters->map(p | $p->transform($extensions)));
 }
 
-function meta::pure::tds::toRelation::fail(f:Function<Any>[1]):meta::pure::functions::collection::Pair<Function<Any>, FunctionDefinition<{->AppliedFunction[1]}>>[1]
+
+
+function meta::pure::tds::toRelation::swap(f:Function<Any>[1], o:Function<Any>[1], a:AppliedFunction[1], extensions:Extension[*]):meta::pure::functions::collection::Pair<Function<Any>, FunctionDefinition<{->AppliedFunction[1]}>>[1]
 {
-  pair($f, | fail('currently no translation for function ' + $f.name->toOne()); appliedFunction($f, []);)
+  pair($f, | appliedFunction($o, $a.parameters->map(p | $p->transform($extensions))))
 }
 
 function meta::pure::tds::toRelation::colsToColSpecArrayInstance(params:meta::protocols::pure::vX_X_X::metamodel::m3::valuespecification::ValueSpecification[*], extensions:Extension[*]):ClassInstance[1]

legend-engine-xts-relationalStore/legend-engine-xt-relationalStore-generation/legend-engine-xt-relationalStore-pure/legend-engine-xt-relationalStore-core-pure/src/main/resources/core_relational/relational/tds/relation/tdsToRelation.pure

@@ -51,9 +51,7 @@ function meta::pure::tds::toRelation::tdsToRelationExtension():TdsToRelationExte
                 let func = $a.parameters->at(3)->transform($extensions);
 
                 appliedFunction(join_Relation_1__Relation_1__JoinKind_1__Function_1__Relation_1_, [$left, $right, $joinKind, $func]);
-            ),
-            fail(tableToTDS_Table_1__TableTDS_1_),
-            fail(meta::pure::tds::extensions::columnValueDifference_TabularDataSet_1__TabularDataSet_1__String_$1_MANY$__String_$1_MANY$__TabularDataSet_1_)
+            )
           ]
         }
       )

legend-engine-xts-sql/legend-engine-xt-sql-http-api/src/main/java/org/finos/legend/engine/query/sql/api/SQLExecutor.java

@@ -237,11 +237,14 @@ private Root_meta_external_query_sql_transformation_queryToPure_PlanGenerationRe
 
         if (result._plan() == null)
         {
-            Lambda lambda = read(result._lambda(), Lambda.class);
-            FunctionDefinition<?> func = HelperValueSpecificationBuilder.buildLambda(lambda, pureModel.getContext());
-            FunctionDefinition<?> func2 = core_pure_router_preeval_preeval.Root_meta_pure_router_preeval_preval_FunctionDefinition_1__Extension_MANY__FunctionDefinition_1_(func, routerExtensions.apply(pureModel), pureModel.getExecutionSupport());
-            Root_meta_pure_executionPlan_ExecutionPlan plan = PlanGenerator.generateExecutionPlanAsPure(func2, result._mapping(), result._runtime(), null, pureModel, PlanPlatform.JAVA, null, routerExtensions.apply(pureModel));
-            result._plan(plan);
+            TraceUtils.trace("generating plan", span ->
+            {
+                Lambda lambda = read(result._lambda(), Lambda.class);
+                FunctionDefinition<?> func = HelperValueSpecificationBuilder.buildLambda(lambda, pureModel.getContext());
+                FunctionDefinition<?> func2 = core_pure_router_preeval_preeval.Root_meta_pure_router_preeval_preval_FunctionDefinition_1__Extension_MANY__FunctionDefinition_1_(func, routerExtensions.apply(pureModel), pureModel.getExecutionSupport());
+                Root_meta_pure_executionPlan_ExecutionPlan plan = PlanGenerator.generateExecutionPlanAsPure(func2, result._mapping(), result._runtime(), null, pureModel, PlanPlatform.JAVA, null, routerExtensions.apply(pureModel));
+                result._plan(plan);
+            });
         }
         else
         {