Bug: OneDrive icon is missing for the "syncing" state

[lfrvasseur]

What feature or improvement do you think would benefit Files?

The Files app looks good, works fine, and has a lot of features that weren't available in the original Explorer. I (also) work a lot with OneDrive and it would be a welcome addition to be able to see if a file or folder is synced with OneDrive.

Steps to repro

• Start downloading or uploading large file in OneDrive
• Observe that the "syncing" state icon isn't displayed

Files Version

3.7.7.0

Windows Version

10.0.22631.4169

Comments

No response

[Josh65-2201]

Thanks for the feedback, Files already supports this. Please screenshot Files compared to Windows File Explorer, And do you have Files on demand enabled in OneDrive?

[lfrvasseur]

I have on demand enabled in OneDrive. When copying a file I see in Files a green icon, meaning the copy has succeeded. In Explorer however I see that a sync is in progress.

[Josh65-2201]

Thanks

[yaira2]

Does the icon show once the file is finished syncing?

[lfrvasseur]

Hi, Hi, the icon shows with the arrows and once it is synced the cloud without the arrows shows. I attached a short video when copying a file to a folder on OneDrive. ​Met vriendelijke groet, Lawrence Vasseur | 0657108755

…

________________________________ Van: Yair ***@***.***> Verzonden: dinsdag 17 september 2024 16:15 Aan: files-community/Files ***@***.***> CC: lfrvasseur ***@***.***>; Author ***@***.***> Onderwerp: Re: [files-community/Files] Bug: OneDrive syncing file icon doesn't show in status column (Issue #16210) Does the icon show once the file is finished syncing? — Reply to this email directly, view it on GitHub<#16210 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BLKSBTWLWBYWQNGJNUS4OWDZXA2PJAVCNFSM6AAAAABOK7UD66VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJVHE3DQOBYGU>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[Josh65-2201]

Email attachments don't work. You will have to click the View on GitHub link at the bottom of the email > Copy and paste or click the add attachment button to select the file > Wait until you don't see uploading in the text > Click the green comment button.

[lfrvasseur]

Sync.cloud.onedrive.mp4

[yaira2]

Thank you for confirming, there must be an issue where the icon for the syncing state is missing.

[yaira2]

I tested on my side and the syncing icon was displayed when downloading a large file. Can you upload the log file?

[lfrvasseur]

debug.log
Hi,
Do you see the Icon in de bar (path), just like in the default explorer? I see nothing that tells me it is syncing.

[yaira2]

I don't see any issues listed in the log file

[lfrvasseur]

I will uninstall and re-install Files tomorrow and see what happens.

[Josh65-2201]

Files doesn't show sync status in the path bar, It shows it in the status column of each file/folder

[lfrvasseur]

I do see it and there was probably a miscommunication there. A note: you don't see that syncing is going on, only when the syncing is done you see a green checkmark. It might be an idea to create a status bar or something similar there so that the user can see that there is syncing. ​Met vriendelijke groet, Lawrence Vasseur | 0657108755

…

________________________________ Van: Josh65-2201 ***@***.***> Verzonden: vrijdag 20 september 2024 00:02 Aan: files-community/Files ***@***.***> CC: lfrvasseur ***@***.***>; Author ***@***.***> Onderwerp: Re: [files-community/Files] Bug: OneDrive icon is missing for the "syncing" state (Issue #16210) Files doesn't show sync status in the path bar, It shows it in the status column of each file/folder — Reply to this email directly, view it on GitHub<#16210 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BLKSBTQFV3YDOAJF6ROSMGLZXNCYBAVCNFSM6AAAAABOK7UD66VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRSGI3TSMBSGQ>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[BoudinDjama]

Hi @yaira2 ,

I’d like to work on this issue. My understanding is that the cloud icon should display a check mark once syncing is complete. Should the icon first show a temporary cloud with a check mark and then revert to just the cloud, or would the entire cloud icon turn into a check mark? I’m a beginner and would appreciate any guidance or suggestions. Thank you!

[yaira2]

The icons should match the sync state. I believe it's a timing issue as reloading the folder usually displays the icons properly.

[BoudinDjama]

Ok, so would you have any advice or suggestions on how to trigger an icon update in real-time, or should I focus on adding a manual refresh trigger?

[yaira2]

I don't have the code in front of me right now, but the best thing would be to look at the code for loading the sync status.

[BoudinDjama]

Hello @yaira2

This is what I found out so far:

the sync status is determined in CheckCloudDriveSyncStatusAsync(IStorage item). It retrieves windows files properties (System.FilePlaceholderStatus & System.FileOfflineAvailablilityStatus). Then the result is converted to CloudDriveSyncStatus enum where 9 is "syncing" (What I need).

CloudDriveSyncStatusUI.cs handles the ui mapping for the status. syncStatus is used in ShellViewModel.cs but I can't figure out how it propagates to the UI. When I run the project and double click on the green check mark it brings me to AddressToolbar.xaml and points to <button x:Name="ShowStatusCenterButton". Which gets me confused.

Can you provide me with some guidance on how to make changes to that "button"?

Thanks

[yaira2]

The UI is part of the item template for each layout.