Skip to content

Commit b7d531e

Browse files
Lukiluc290x5bfa
andauthored
Code Quality: Formatting Issue with Dimensions and Synchronization Labels (#15621)
Co-authored-by: 0x5BFA <[email protected]>
1 parent e2c7b25 commit b7d531e

File tree

3 files changed

+11
-5
lines changed

3 files changed

+11
-5
lines changed

src/Files.App/Data/Items/ListedItem.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,9 +47,9 @@ public string ItemTooltipText
4747
if (!string.IsNullOrWhiteSpace(FileSize))
4848
tooltipBuilder.Append($"{Environment.NewLine}{"SizeLabel".GetLocalizedResource()} {FileSize}");
4949
if (!string.IsNullOrWhiteSpace(DimensionsDisplay))
50-
tooltipBuilder.Append($"{Environment.NewLine}{"PropertyDimensions".GetLocalizedResource()}: {DimensionsDisplay}");
50+
tooltipBuilder.Append($"{Environment.NewLine}{"PropertyDimensionsColon".GetLocalizedResource()} {DimensionsDisplay}");
5151
if (SyncStatusUI.LoadSyncStatus)
52-
tooltipBuilder.Append($"{Environment.NewLine}{"syncStatusColumn/Header".GetLocalizedResource()}: {syncStatusUI.SyncStatusString}");
52+
tooltipBuilder.Append($"{Environment.NewLine}{"StatusWithColon".GetLocalizedResource()} {syncStatusUI.SyncStatusString}");
5353

5454
return tooltipBuilder.ToString();
5555
}

src/Files.App/Strings/en-US/Resources.resw

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -396,7 +396,7 @@
396396
<data name="HoursAgo" xml:space="preserve">
397397
<value>{0, plural, one {# hour ago} other {# hours ago}}</value>
398398
</data>
399-
<data name="HoursAgo_Singular" xml:space="preserve">
399+
<data name="HoursAgo_Singular" xml:space="preserve">
400400
<value>1 hour ago</value>
401401
</data>
402402
<data name="HoursAgo_Plural" xml:space="preserve">
@@ -512,7 +512,7 @@
512512
<data name="TabStripDragAndDropUIOverrideCaption" xml:space="preserve">
513513
<value>Move tab here</value>
514514
</data>
515-
<data name="syncStatusColumn.Header" xml:space="preserve">
515+
<data name="Status" xml:space="preserve">
516516
<value>Status</value>
517517
</data>
518518
<data name="SettingsPreferencesSystemDefaultLanguageOption" xml:space="preserve">
@@ -3853,4 +3853,10 @@
38533853
<data name="EditInNotepadDescription" xml:space="preserve">
38543854
<value>Edit the selected file in Notepad</value>
38553855
</data>
3856+
<data name="PropertyDimensionsColon" xml:space="preserve">
3857+
<value>Dimensions:</value>
3858+
</data>
3859+
<data name="StatusWithColon" xml:space="preserve">
3860+
<value>Status:</value>
3861+
</data>
38563862
</root>

src/Files.App/Views/Layouts/DetailsLayoutPage.xaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -870,7 +870,7 @@
870870
HorizontalContentAlignment="Left"
871871
Command="{x:Bind UpdateSortOptionsCommand, Mode=OneWay}"
872872
CommandParameter="SyncStatus"
873-
Header="{helpers:ResourceString Name=syncStatusColumn/Header}"
873+
Header="{helpers:ResourceString Name=Status}"
874874
Visibility="{x:Bind ColumnsViewModel.StatusColumn.Visibility, Mode=OneWay}" />
875875

876876
<!-- (Divider) -->

0 commit comments

Comments
 (0)