Bitswap crashes after upgrade #13225
Description
Boxo / bitswap upgrade has caused some problems, regular crashing using the latest master, reported by @hanabi1224, but I have the same thing now that I go look in my systemd journal:
Jul 21 18:20:30 fletcher lotus[1724181]: panic: runtime error: invalid memory address or nil pointer dereference
Jul 21 18:20:30 fletcher lotus[1724181]: [signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0x2602da6]
Jul 21 18:20:30 fletcher lotus[1724181]: goroutine 929164219 [running]:
Jul 21 18:20:30 fletcher lotus[1724181]: github.com/ipfs/boxo/bitswap/message.newMessageFromProto(0xc058eb2380)
Jul 21 18:20:30 fletcher lotus[1724181]: /home/rvagg/go/pkg/mod/github.com/ipfs/[email protected]/bitswap/message/message.go:193 +0x26
Jul 21 18:20:30 fletcher lotus[1724181]: github.com/ipfs/boxo/bitswap/message.FromMsgReader({0x77fad0d3bab8, 0xc6a128d200})
Jul 21 18:20:30 fletcher lotus[1724181]: /home/rvagg/go/pkg/mod/github.com/ipfs/[email protected]/bitswap/message/message.go:438 +0xaf
Jul 21 18:20:30 fletcher lotus[1724181]: github.com/ipfs/boxo/bitswap/network/bsnet.(*impl).handleNewStream(0xc05a5494a0, {0x72be528, 0xc05c4b5680})
Jul 21 18:20:30 fletcher lotus[1724181]: /home/rvagg/go/pkg/mod/github.com/ipfs/[email protected]/bitswap/network/bsnet/ipfs_impl.go:445 +0x2a5
Jul 21 18:20:30 fletcher lotus[1724181]: github.com/libp2p/go-libp2p/p2p/host/basic.(*BasicHost).SetStreamHandler.func1({0x0?, 0x0?}, {0x77fac7ed8fa0?, 0xc05c4b5680?})
Jul 21 18:20:30 fletcher lotus[1724181]: /home/rvagg/go/pkg/mod/github.com/libp2p/[email protected]/p2p/host/basic/basic_host.go:557 +0x82
Jul 21 18:20:30 fletcher lotus[1724181]: github.com/libp2p/go-libp2p/p2p/host/basic.(*BasicHost).newStreamHandler(0xc000a0a000, {0x72be528, 0xc05c4b5680})
Jul 21 18:20:30 fletcher lotus[1724181]: /home/rvagg/go/pkg/mod/github.com/libp2p/[email protected]/p2p/host/basic/basic_host.go:405 +0x7f7
Jul 21 18:20:30 fletcher lotus[1724181]: github.com/libp2p/go-libp2p/p2p/net/swarm.(*Conn).start.func1.1()
Jul 21 18:20:30 fletcher lotus[1724181]: /home/rvagg/go/pkg/mod/github.com/libp2p/[email protected]/p2p/net/swarm/swarm_conn.go:155 +0xa5
Jul 21 18:20:30 fletcher lotus[1724181]: created by github.com/libp2p/go-libp2p/p2p/net/swarm.(*Conn).start.func1 in goroutine 929155014
Jul 21 18:20:30 fletcher lotus[1724181]: /home/rvagg/go/pkg/mod/github.com/libp2p/[email protected]/p2p/net/swarm/swarm_conn.go:141 +0x1ab
Related to #13202