Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: replace figma.d.ts from samples/react with @figma/plugin-typings #22

Closed
Robbie-Cook opened this issue Aug 5, 2020 · 1 comment
Closed

Feature request: replace figma.d.ts from samples/react with @figma/plugin-typings #22

Robbie-Cook opened this issue Aug 5, 2020 · 1 comment

Comments

@Robbie-Cook
Copy link
Contributor

Hey!

At the moment, figma typings are hard-coded to figma.d.ts in the React sample

Similar to #3 , I was wondering if instead of using a figma.d.ts file in the React sample, we could add @figma/plugin-typings to the dev dependencies, so that users are able to update their figma typings if they change after they pull the sample.

Thanks!
@adispezio
Copy link
Contributor

Good call out! The typings are now a dev dependency in the root and updated all tsconfigs in the samples to point there. The webpack + react example still pulls its own copy for completeness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adispezio @Robbie-Cook