Handling incorrect entry to of github handle in Airtable

[martapiekarska]

When an applicant puts in their github handle as a link or with an @ at the beginning link to their github account throws 404 as the link is formed by taking the input and adding it to the end of "https://github.com/"
Examples

[JAG-UK]

OK 2 different places we could fix this:

• We already do all kinds of stripping of GitHub IDs in the 'OtherGithubHandles' entry to get rid of illegal characters, whitespace and so on, so we could do that for the main handle too and add '@' to the set of things to remove
• We could just special-case stripping of @ when we render the link

The former is more robust as it'll pick up this issue everywhere the handle might be used now and in the future

[martapiekarska]

Either is good, but there are also people who put in a full link, which isnt handled correctly. ""https://github.com/cryptowhizzard" in the airtable turns into "https://github.com/https://github.com/cryptowhizzard" in the dashboard

[JAG-UK]

Yuk. I don't love the idea of accepting and rendering user-supplied fields with links in them. But in this case sanitizing isn't very hard. Shall we say:

• If it starts with 'https://github.com/' or 'https://www.github.com/' and is followed by exactly one word that is a legal user name (modulo a potential trailing '/'), then we extract the last word as a github username, strip any trailing '/' and then carry on as now.
• If it starts with an '@', just strip the '@' and carry on as now
• Else render as now unprocessed, and if it's broken then it's broken. At some point mistakes can't be prevented.

Maybe an added line of description to the Airtable could reduce scope for legal formats.

[martapiekarska]

I added helper text in the form to input in correct format. I tried adding validation in airtable but it famously doesnt support that. But we need to fix it for the following entries in mongo:

https://github.com/cryptowhizzard
https://github.com/cryptowhizzard
@FroghubMan
@amiable169
@revelation2525
@liyunzhi-666
@Marshall-btc
@joshua-ne

[JAG-UK]

Cool I can fix those in Mongo now. To stop it happening again according to the suggestion above we can add sanitzing/validation logic to the back end code that reads Airtable entries.

[JAG-UK]

OK those are all fixed and linking correctly on apply.allocator.tech now.

I noticed 4 other invalid records in the database while doing this. What would you like done with these?

• StorageDAO has provided a list. Which do we take as primary? { github: "pixbot512, nodedao" }
• FutureStorage has provided a list. Which do we take as primary? { github: "chainupk, Tom-OriginStorage" }
• ND Labs have 2 entries specifying an invalid name - can we trace this to a real GitHub user name? { github: "ND labs - Leo"}

[martapiekarska]

I think it is the firsdt one that is primary, should I check in the application?

[martapiekarska]

@JAG-UK what is the status of this?

[JAG-UK]

what is the status of this?

I was waiting for a definitive answer to my question. I see on Slack ND Labs and Joshua-ne have provided an answer so I've done those.