From 920207f4a32ebf8677f8b7889b8fa8fce1b0a0f6 Mon Sep 17 00:00:00 2001 From: Felix Wiedenbach Date: Mon, 2 Oct 2023 23:24:04 +0200 Subject: [PATCH] Fixed timing of alert click handler registration --- CHANGELOG.md | 6 ++++++ MMM-AlarmClock.js | 21 +++++++++++---------- package-lock.json | 2 +- package.json | 2 +- 4 files changed, 19 insertions(+), 12 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 502d6b7..d46acc2 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,11 @@ # MMM-AlarmClock Changelog +## [2.0.2] + +### Fixed + +* Timing of alert click handler registration + ## [2.0.1] ### Fixed diff --git a/MMM-AlarmClock.js b/MMM-AlarmClock.js index bb89571..0a0d02d 100644 --- a/MMM-AlarmClock.js +++ b/MMM-AlarmClock.js @@ -183,7 +183,7 @@ Module.register('MMM-AlarmClock', { */ notificationReceived(notification) { if (notification === 'STOP_ALARM') { - this.resetAlarmClock() + this.resetAlarmClock(); } }, @@ -216,16 +216,17 @@ Module.register('MMM-AlarmClock', { this.timer = setTimeout(() => { this.resetAlarmClock(); }, timer); - if (this.config.touch && this.config.popup) { - MM.getModules().enumerate(module => { - if (module.name === 'alert') { - module.alerts['MMM-AlarmClock'].ntf.addEventListener('click', () => { - this.resetAlarmClock(); - }); - } - }); - } setTimeout(() => { + if (this.config.touch && this.config.popup) { + MM.getModules().enumerate(module => { + if (module.name === 'alert') { + module.alerts['MMM-AlarmClock'].ntf.addEventListener('click', () => { + this.resetAlarmClock(); + }); + } + }); + } + const player = document.getElementById('MMM-AlarmClock-Player'); player.volume = this.config.fade ? 0 : this.config.volume; this.fadeAlarm(); diff --git a/package-lock.json b/package-lock.json index 1133df7..665ff5e 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,6 +1,6 @@ { "name": "mmm-alarmclock", - "version": "2.0.1", + "version": "2.0.2", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/package.json b/package.json index 70b8d95..e9590be 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "mmm-alarmclock", - "version": "2.0.1", + "version": "2.0.2", "description": "Alarm Clock Module for MagicMirror2", "scripts": { "lint": "./node_modules/.bin/eslint . && ./node_modules/.bin/stylelint .",