Skip to content

Commit 2ad55da

Browse files
zachcpclaude
andauthored
Fix P2/P3 rerun-example follow-up beads + version bumps (#168)
* fix: crate-bump * fix: bump * fix: resolve P2/P3 rerun-example follow-up beads - Fix rerun example imports (ferritin_bevy + load_model) so it compiles after the ferritin-structure-mesh -> ferritin-bevy rename (ferritin-3g7, a P1 blocker for ferritin-s0s below) - Add CI cargo-check coverage for all-targets, rerun-gated ferritin-bevy, and the rerun example itself (gated to push-to-main, since it pulls re_viewer) so this class of regression fails CI instead of only appearing in the editor (ferritin-s0s) - Purge remaining ferritin-structure-mesh references: drop the empty crate shell dir, stale .gitignore entry, stale deps.txt dump, and fix dead links in crates/Readme.md and docs/index.qmd (ferritin-eop) - Add .vscode/settings.json enabling the 'rerun' cargo feature for rust-analyzer so it stops reporting phantom unresolved-import errors on the rerun example (ferritin-5n5) Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
1 parent f2eab81 commit 2ad55da

8 files changed

Lines changed: 23 additions & 3148 deletions

File tree

.beads/interactions.jsonl

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -142,3 +142,7 @@
142142
{"id":"int-83b2e5f83d403908d2ee71bb333b941f","kind":"field_change","created_at":"2026-07-19T14:40:53.917458Z","actor":"Zachary Charlop-Powers","issue_id":"ferritin-u87","extra":{"field":"status","new_value":"closed","old_value":"in_progress","reason":"Implemented and verified with ferritin-core tests plus workspace build/check."}}
143143
{"id":"int-af12d48842ab6a3216edc7d4d58d5051","kind":"field_change","created_at":"2026-07-19T14:40:54.250833Z","actor":"Zachary Charlop-Powers","issue_id":"ferritin-tnk","extra":{"field":"status","new_value":"closed","old_value":"in_progress","reason":"Implemented and verified with ferritin-core tests plus workspace build/check."}}
144144
{"id":"int-f2145e92e068399b9d68ca646e5d2306","kind":"field_change","created_at":"2026-07-19T15:12:17.20407Z","actor":"Zachary Charlop-Powers","issue_id":"ferritin-229","extra":{"field":"status","new_value":"closed","old_value":"in_progress","reason":"Implemented and verified zero-copy biological and crystallographic symmetry expansion in ferritin-core."}}
145+
{"id":"int-c9b5d4f4fb5da3d9bbf631c49625026b","kind":"field_change","created_at":"2026-08-29T17:21:37.638323Z","actor":"Zachary Charlop-Powers","issue_id":"ferritin-3g7","extra":{"field":"status","new_value":"closed","old_value":"in_progress","reason":"Fixed imports: ferritin_bevy::{ColorScheme,RenderOptions,Structure,ToRerun}, ferritin_core::load_model. Verified with cargo check -p ferritin-examples --features rerun --example rerun (clean compile)."}}
146+
{"id":"int-248fefa9897b912e79c5c3406041d3c3","kind":"field_change","created_at":"2026-08-29T17:21:59.966216Z","actor":"Zachary Charlop-Powers","issue_id":"ferritin-s0s","extra":{"field":"status","new_value":"closed","old_value":"in_progress","reason":"Added three cargo check steps to .github/workflows/tests.yaml: (1) cargo check --workspace --all-targets on every run, (2) cargo check -p ferritin-bevy --features rerun on every run (both verified locally, warnings only), (3) cargo check -p ferritin-examples --features rerun --example rerun gated to push-to-main only since it pulls re_viewer (~10min cold), per the tradeoff noted in the bead."}}
147+
{"id":"int-2b509df3d74e1e4e8d2eb38b250aa018","kind":"field_change","created_at":"2026-08-29T17:23:35.426357Z","actor":"Zachary Charlop-Powers","issue_id":"ferritin-eop","extra":{"field":"status","new_value":"closed","old_value":"in_progress","reason":"Deleted empty crates/ferritin-structure-mesh/ shell dir; removed deps.txt (stale generated dump, unreferenced); dropped .gitignore line for the removed dir; fixed crates/Readme.md:31 link to ./ferritin-bevy; fixed docs/index.qmd heading + both dead URLs (rust-docs and source, updated source path to crates/ferritin-bevy). Remaining structure-mesh references are in justfile (owned by separate P1 bead ferritin-nzn) and one historical string in .claude/settings.local.json, both explicitly out of scope."}}
148+
{"id":"int-8dc4d2960f8a0114e61f81355a8b5712","kind":"field_change","created_at":"2026-08-29T17:24:00.814139Z","actor":"Zachary Charlop-Powers","issue_id":"ferritin-5n5","extra":{"field":"status","new_value":"closed","old_value":"in_progress","reason":"Added .vscode/settings.json with rust-analyzer.cargo.features:[\"rerun\"] so the analyzer resolves rerun/ColorScheme/RenderOptions/etc. in the rerun example instead of reporting phantom unresolved-import errors. Accepted the cold-build cost per the bead's tradeoff discussion since it only affects opt-in editor analysis, not CI. .idea/workspace.xml's stale feature names need no cleanup: .idea/ is already git-ignored (.gitignore:3) and was never tracked (confirmed via git ls-files), so it carries no repo-visible staleness."}}

.github/workflows/tests.yaml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,5 +31,15 @@ jobs:
3131
- name: Run Build
3232
run: cargo build
3333

34+
- name: Check all targets (examples, tests, benches)
35+
run: cargo check --workspace --all-targets
36+
37+
- name: Check rerun-gated code
38+
run: cargo check -p ferritin-bevy --features rerun
39+
40+
- name: Check rerun example
41+
if: github.event_name == 'push' && github.ref == 'refs/heads/main'
42+
run: cargo check -p ferritin-examples --features rerun --example rerun
43+
3444
- name: Run tests
3545
run: cargo test --verbose

.gitignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
.DS_Store
55

66

7-
crates/ferritin-structure-mesh/wasm-examples/
87
docs/doc
98

109
# Beads / Dolt files (added by bd init)

.vscode/settings.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
{
2+
"rust-analyzer.cargo.features": ["rerun"]
3+
}

crates/Readme.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ PLMs (Protein Language Models) integration for ferritin.
2828

2929
Cell visualization and analysis tools for ferritin.
3030

31-
## [ferritin-bevy](./ferritin-structure-mesh)
31+
## [ferritin-bevy](./ferritin-bevy)
3232

3333
Bevy game engine integration for ferritin.
3434

crates/ferritin-examples/examples/rerun/main.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
use anyhow::Result;
22
use bevy::prelude::*;
3-
use ferritin_core::load_structure;
4-
use ferritin_structure_mesh::{ColorScheme, RenderOptions, Structure, ToRerun};
3+
use ferritin_bevy::{ColorScheme, RenderOptions, Structure, ToRerun};
4+
use ferritin_core::load_model;
55
use ferritin_test_data::TestFile;
66
use rerun::Mesh3D;
77

@@ -12,7 +12,7 @@ fn main() -> Result<()> {
1212

1313
// Load the structure
1414
let (molfile, _handle) = TestFile::protein_01().create_temp()?;
15-
let ac = load_structure(molfile)?;
15+
let ac = load_model(molfile)?;
1616

1717
// Define a few materials
1818
let chalky = StandardMaterial {

0 commit comments

Comments
 (0)