-
-
Notifications
You must be signed in to change notification settings - Fork 790
fix(generators): remove ctx.cwd from prettier.resolveConfig() #3554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dove
Are you sure you want to change the base?
Conversation
prettier.resolveConfig() should either be called with a concrete config file or without any parameters. with just a directory it fails to resolve correctly
|
Thank you for the pull request. It looks like the types require a parameter which is why the compile step fails. What does the current failure look like? |
it doesn't pick up the empty string works because there's a check for |
|
|
not sure |
e-kibet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fix prettier formating in generators
prettier.resolveConfig() should either be called with a concrete config file or without any parameters. with just a directory it fails to resolve correctly