[Dove] Drop reliance on legacy runtime compatibility settings

[FossPrime]

Running the Quick Start with typescript defaults returns the following error when executed with tsc app.ts unless a tsconfig file is made and a handful of legacy compatibility features are turned on.

SyntaxError: The requested module '@feathersjs/koa' does not provide an export named 'bodyParser'

Reproduction: https://stackblitz.com/edit/node-lzf6x8?file=package.json,app.ts

Upon some debugging, body parser is not exported at top level... but in a property called default:

❯ tsx
Welcome to tsx v3.9.0 (Node.js v16.14.2).
Type ".help" for more information.
> import('@feathersjs/koa').then(console.log)
Promise { <unknown> }
> [Module: null prototype] {
  default: {
    Koa: [Getter],
    bodyParser: [Getter],
    koa: [Function: koa],
    parseAuthentication: [Getter],
    authenticate: [Getter],
    errorHandler: [Getter],
    formatter: [Getter],
    rest: [Getter]
  },
  __esModule: true,
  koa: [Function: koa],
  authenticate: [Function: authenticate],
  parseAuthentication: [Function: parseAuthentication],
  errorHandler: [Function: errorHandler],
  rest: [Function: rest],
  formatter: [Function: formatter]
}

Proposed Solutions:

1. Use tsup to automatically wrap the typescript modules for cjs and esm import.
2. Drop support for CommonJs projects in new versions and only build for ES modules

Workarounds

1. Using esno
2. manually pick and hunt for dependencies within the CJS package

Additional Notes

• While TS 4.7 supports loading modules with Node natively, Vite does not. Support Typescript 4.7 "Node16" extension requirements vitejs/vite#8993 (comment)
  • This causes problems when using build plugins as it's hard to get everyone to agree without support for Node's native behavior.

[daffl]

This looks like providing an ESM build which we've been trying to do in #2665 can't seem to get it working properly in an at least somewhat backwards compatible way. I'd be happy if someone wants to take on digging more into this.

[FossPrime]

This looks like providing an ESM build which we've been trying to do in #2665 can't seem to get it working properly in an at least somewhat backwards compatible way. I'd be happy if someone wants to take on digging more into this.

It's not a small job to it while ensuring backward compatibility. Each module in the mono repo is different.
I suggest accepting PR's for supporting ESM builds, one or two modules at a time. The most correct way to it that I know is defining all the exports that are used. That breaks builds when people access random files within our packages

Though again, one thing that would be a HUGE help, would be to encourage using .js extensions in TypeScript now.

[FossPrime]

Building a TypeScript version of feathers-memory

DTS Build start
src/index.ts(1,20): error TS2792: Cannot find module '@feathersjs/errors'.
src/index.ts(2,19): error TS2792: Cannot find module '@feathersjs/commons'.
src/index.ts(3,48): error TS2792: Cannot find module '@feathersjs/adapter-commons'.
src/index.ts(4,18): error TS2792: Cannot find module 'sift'.
src/index.ts(6,37): error TS2792: Cannot find module '@feathersjs/adapter-commons'.

PNPM is a great way to make pull requests for a few of these... there's just too much to do all at once. Of course there are 20 lines of training wheels I could add to make it all work, but birds don't ride bikes...

[daffl]

Note that the current Feathers memory has been moved into core as @feathersjs/memory. I just didn't want to add deprecation notices yet since it's not "official".

I'm fairly sure it should build as expected.

[FossPrime]

Note that the current Feathers memory has been moved into core as @feathersjs/memory. I just didn't want to add deprecation notices yet since it's not "official".

I'm fairly sure it should build as expected.

A mail forwarding a dress would have saved a lot of time... Nothing hinted at work being done on somewhere else, there are dove branches there. A mail forwarding address would be nice ;), even months before you move.

Vuetify is full of heads up notices... even though there is no stable up to date version, 20 months after Vue 3 became stable.

The repo, issue tickets and PR system need not be altogether... Those can be moved to the monorepo before this one is ready...