security: refactor ticket creation validation into Form Request

Author: serfersac

app/Http/Controllers/Agent/helpdesk/TicketController.php

@@ -7,11 +7,9 @@
 use App\Http\Controllers\Common\NotificationController as Notify;
 use App\Http\Controllers\Common\PhpMailController;
 use App\Http\Controllers\Controller;
-use App\Http\Requests\helpdesk\CreateTicketRequest;
-// requests
 use App\Http\Requests\helpdesk\TicketRequest;
+use App\Http\Requests\TicketStoreRequest;
 use App\Model\helpdesk\Agent\Department;
-// models
 use App\Model\helpdesk\Agent\Teams;
 use App\Model\helpdesk\Email\Emails;
 use App\Model\helpdesk\Form\Fields;
@@ -99,7 +97,7 @@ public function newticket(CountryCode $code)
      *
      * @return type response
      */
-    public function post_newticket(CreateTicketRequest $request, CountryCode $code, $api = false)
+    public function post_newticket(TicketStoreRequest $request, CountryCode $code, $api = false)
     {
         try {
             if ($request->input('email')) {

app/Http/Requests/TicketStoreRequest.php

@@ -0,0 +1,34 @@
+<?php
+
+namespace App\Http\Requests;
+
+use Illuminate\Foundation\Http\FormRequest;
+
+class TicketStoreRequest extends FormRequest
+{
+    /**
+     * Determine if the user is authorized to make this request.
+     *
+     * @return bool
+     */
+    public function authorize()
+    {
+        return true;
+    }
+
+    /**
+     * Get the validation rules that apply to the request.
+     *
+     * @return array
+     */
+    public function rules()
+    {
+        return [
+            'subject' => 'required|string|max:255',
+            'body' => 'required|string',
+            'first_name' => 'required|string|max:255',
+            'last_name' => 'required|string|max:255',
+            'email' => 'required|email',
+        ];
+    }
+}