Skip to content

Colorized string doesn't get underlined correctly #233

@nobe4

Description

@nobe4

Consider the following code:

package main

import (
	"fmt"

	"github.com/fatih/color"
)

func main() {
	a := color.New(color.FgRed).SprintFunc()("aaa")
	b := color.New(color.FgBlue).SprintFunc()("bbb")
	c := color.New(color.Underline).SprintFunc()(a + b)
	fmt.Println(c)

	d := color.New(color.Underline).SprintFunc()("aaabbb")
	fmt.Println(d)
}

Image

I would expect the Underline to apply to the whole colorized string.

This is adapted of how I use it in

The issue seems to come from the usage of wrap in https://github.com/fatih/color/blob/main/color.go#L353-L357. It seems that unformat resets the entire format, not just the colors.

Is this expected?
If so, which approach would you recommend to make a colorized string fully underlined?

Thanks!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions