Skip to content

Commit 251c037

Browse files
authored
fix: If request does not have a static backend defined, return undefined for the Request.prototype.backend getter (#722)
1 parent 17fbdf5 commit 251c037

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

runtime/js-compute-runtime/builtins/request-response.cpp

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1263,11 +1263,7 @@ bool Request::bodyAll(JSContext *cx, unsigned argc, JS::Value *vp) {
12631263
bool Request::backend_get(JSContext *cx, unsigned argc, JS::Value *vp) {
12641264
METHOD_HEADER(0)
12651265
JS::RootedValue backend(cx, JS::GetReservedSlot(self, static_cast<uint32_t>(Slots::Backend)));
1266-
if (backend.isNullOrUndefined()) {
1267-
args.rval().setString(JS_GetEmptyString(cx));
1268-
} else {
1269-
args.rval().set(backend);
1270-
}
1266+
args.rval().set(backend);
12711267

12721268
return true;
12731269
}

types/globals.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1084,7 +1084,7 @@ interface Request extends Body {
10841084
clone(): Request;
10851085

10861086
// Fastly extensions
1087-
backend: string;
1087+
backend?: string;
10881088
setCacheOverride(override: import('fastly:cache-override').CacheOverride): void;
10891089
setCacheKey(key: string): void;
10901090
setManualFramingHeaders(manual: boolean): void;

0 commit comments

Comments
 (0)