feat: add matrix content scanner support#2332
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2332 +/- ##
==========================================
+ Coverage 55.71% 55.90% +0.19%
==========================================
Files 160 161 +1
Lines 19862 19923 +61
==========================================
+ Hits 11066 11138 +72
+ Misses 8796 8785 -11
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
krille-chan
requested changes
May 8, 2026
Contributor
krille-chan
left a comment
krille-chan
left a comment
There was a problem hiding this comment.
@kamor-famedly can you link an issue here?
krille-chan
reviewed
May 8, 2026
krille-chan
approved these changes
May 8, 2026
td-famedly
reviewed
May 11, 2026
kamor-famedly
force-pushed
the
khalil/content-scanner-support
branch
from
c0d2a9e to
14369da
Compare
kamor-famedly
force-pushed
the
khalil/content-scanner-support
branch
2 times, most recently
from
70278e2 to
c247d5a
Compare
kamor-famedly
force-pushed
the
khalil/content-scanner-support
branch
from
c247d5a to
5b0b0fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/famedly/product-management/issues/3861
This PR implements support for routing media downloads through a Matrix content scanner proxy.
When
contentScannerConfigis set, MXC download and thumbnail URLs are resolved against the scanner endpoints.downloadAndDecryptAttachment()now also supports scanner-backed downloads for encryptedattachments by posting the encrypted file metadata to
download_encrypted, then decrypting the returned bytes client-side as before.The implementation was tested end-to-end against our staging server using the local scanner proxy tool at
tool/content_scanner_proxy.dart.