-
-
Notifications
You must be signed in to change notification settings - Fork 991
Description
Currently, all methods except faker.number.bigInt have a fixed default max
option:
faker/src/modules/number/index.ts
Line 25 in bdd55ad
* @param options.max Upper bound for generated number. Defaults to `Number.MAX_SAFE_INTEGER`. |
faker/src/modules/number/index.ts
Line 111 in bdd55ad
* @param options.max Upper bound for generated number, exclusive, unless `multipleOf` or `fractionDigits` are passed. Defaults to `1.0`. |
faker/src/modules/number/index.ts
Line 229 in bdd55ad
* @param options.max Upper bound for generated number. Defaults to `1`. |
faker/src/modules/number/index.ts
Line 279 in bdd55ad
* @param options.max Upper bound for generated number. Defaults to `7`. |
faker/src/modules/number/index.ts
Line 329 in bdd55ad
* @param options.max Upper bound for generated number. Defaults to `15`. |
vs
faker/src/modules/number/index.ts
Line 377 in bdd55ad
* @param options.max Upper bound for generated bigint. Defaults to `min + 999999999999999n`. |
For consistency with the other methods, the max
value should be hardcoded similar to the other methods.
Since this would be a breaking change(?), it should be changed only in the next major version.
Found while reviewing: #3363