Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification - View Route / View All Routes #528

Open
JakeG-9191 opened this issue May 13, 2020 · 8 comments
Open

Clarification - View Route / View All Routes #528

JakeG-9191 opened this issue May 13, 2020 · 8 comments

Comments

@JakeG-9191
Copy link
Contributor

  1. Navigate to Resilience App
  2. Select In Progress Missions to see list of available in progress missions
  3. Note that each mission has a 'view route' item towards the bottom of the card, with a 'master' view route item at the bottom of the page
  4. Clicking on this master view route seems to draft routes for all the routes currently available in the In Progress missions (I could be wrong about this), if this is the case, I would suggest we add more context to the bottom view route so users know it is a master route
  5. I also feel that this view route may have additional complexities when some routes are very far away from one another

Actual
Additional master view route seems to aggregate and show all available routes

Expected / Suggested
Context is modified so that bottom view route is changed to something like 'View All Routes' or 'Master Route', consider further discussion about how this might be impacted as more routes that fall within In Progress get further physically away from one another

Issue-ViewRouteInfoBottom.PNG

@JakeG-9191 JakeG-9191 added bug Something isn't working design Issue for designers enhancement New feature or request good first issue Good for newcomers - will not need full understanding of the code base to get started. labels May 13, 2020
@jwu910
Copy link
Member

jwu910 commented May 14, 2020

Is this a request to change "View Route" for a group to "View All Routes"?

@jwu910 jwu910 removed bug Something isn't working design Issue for designers enhancement New feature or request good first issue Good for newcomers - will not need full understanding of the code base to get started. labels May 14, 2020
@JakeG-9191
Copy link
Contributor Author

Hi @jwu910 , you may notice that clicking on the final view route compiles all routes available within the In Progress tab, currently there is nothing informing the user that this will happen, I propose that the language change to reflect the aggregation of routes

@JakeG-9191 JakeG-9191 changed the title Clarification - Information behind 'master' view route within resilience application Clarification - View Route / View All Routes May 14, 2020
@jwu910
Copy link
Member

jwu910 commented May 15, 2020

@JakeG-9191 https://www.figma.com/file/GLg0zPNnwMEGIb9TytCrxQ/Resilience-App?node-id=29579%3A18608

Looking at the mockups, i think its actually the first "View Route" that is out of place. There is a black bar at the bottom that looks like it could be a button that says "View route for all missions"

Can we change the scope of this to fixing the "view route" and "View Route for All Missions" buttons?

That would include the language change as well as the styling for "View Route" on the card.

@utunga
Copy link
Contributor

utunga commented May 15, 2020

As the developer of this view route thing, it's great that you spotted this UI bug @JakeG-9191. I messed up. Isn't it great that there are already mockups to look at?

So yes @JakeG-9191 if you wanna dive into this please do - and fix it to look like the mockups.

I would suggest the view route component can still be a single component. It gets included in two different contexts already so it should be relatively doable to tell it to render a different way each time.

Per the mockup there are three contexts:

  • The first is the overall bottom of VolunteerHome (but only when in the 'in progress' view). This needs to rendered as 'view all missions' per the mockup, with the black bar.

  • The other is when a group of missions is grouped together in a 'MissionGroup'. which should be rendered pretty similar to now, but there is something wrong with align

  • The third case I didn't implement. Viewing the route for a single isolated mission doesn't really require any calculations you can just go from a-b, so it's not really a 'route'. At the moment when you click either address it pops up the google maps address thing but with only one address highlighted.

For this third case I don't think we use the 'view route' button rendering at all. In other designs I'm pretty sure they decided to re-use that screen real estate for other things so maybe we just make it that if they click on either address it shows the route from pickup to drop off. If you look at the code you'll see that this would be a relatively easy change, just wahck another address in there separated by a "/". ( I realize that this would contradict the mockup but I think tis the best solution because as I say there are other mockups where they use that space for an 'unassign me' button. )

Thanks!

@utunga
Copy link
Contributor

utunga commented May 15, 2020

Also, I'm not sure if there is any value in not showing a "view route" button for groups of missions on the available and assigned views -- so I suggest we add that as a feature there contradicting the mockups (but saving us the hassle of having to pass state down into the MissionGroup button)

@jwu910
Copy link
Member

jwu910 commented May 15, 2020

@utunga can we jsut ping design for an updated mockup and get some direction on this?

@karenkun
Copy link

There are 3 instances of the "view route" functionality. I've attached a gif of how it works and should look like.

Re: the last view route button --- its basically viewing the route for ALL missions on the page (individual and groups) and creating a driving route for it.

It seems like what's in dev is that that black button is misnamed.
Hopefully this clarifies a bit?

May-14-2020 21-57-56

@utunga
Copy link
Contributor

utunga commented May 16, 2020

Thanks Karen, yes that is helpful and the animation is awesome.

Couple of things about the 'view route' on a single mission :

  • Do we need that screen real estate for a 'unassign me' button? In some other situations that is there? As far as I know you can 'unassign' yourself right up till a mission has been started
  • What do the two address links take you to?

Also perhaps the view route functionality should be available for the 'assigned' stage as well as the 'in progress' stage? I don't see why not? Why not even the suggested stage?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants