-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarification - View Route / View All Routes #528
Comments
Is this a request to change "View Route" for a group to "View All Routes"? |
Hi @jwu910 , you may notice that clicking on the final view route compiles all routes available within the In Progress tab, currently there is nothing informing the user that this will happen, I propose that the language change to reflect the aggregation of routes |
@JakeG-9191 https://www.figma.com/file/GLg0zPNnwMEGIb9TytCrxQ/Resilience-App?node-id=29579%3A18608 Looking at the mockups, i think its actually the first "View Route" that is out of place. There is a black bar at the bottom that looks like it could be a button that says "View route for all missions" Can we change the scope of this to fixing the "view route" and "View Route for All Missions" buttons? That would include the language change as well as the styling for "View Route" on the card. |
As the developer of this view route thing, it's great that you spotted this UI bug @JakeG-9191. I messed up. Isn't it great that there are already mockups to look at? So yes @JakeG-9191 if you wanna dive into this please do - and fix it to look like the mockups. I would suggest the view route component can still be a single component. It gets included in two different contexts already so it should be relatively doable to tell it to render a different way each time. Per the mockup there are three contexts:
For this third case I don't think we use the 'view route' button rendering at all. In other designs I'm pretty sure they decided to re-use that screen real estate for other things so maybe we just make it that if they click on either address it shows the route from pickup to drop off. If you look at the code you'll see that this would be a relatively easy change, just wahck another address in there separated by a "/". ( I realize that this would contradict the mockup but I think tis the best solution because as I say there are other mockups where they use that space for an 'unassign me' button. ) Thanks! |
Also, I'm not sure if there is any value in not showing a "view route" button for groups of missions on the available and assigned views -- so I suggest we add that as a feature there contradicting the mockups (but saving us the hassle of having to pass state down into the MissionGroup button) |
@utunga can we jsut ping design for an updated mockup and get some direction on this? |
There are 3 instances of the "view route" functionality. I've attached a gif of how it works and should look like. Re: the last view route button --- its basically viewing the route for ALL missions on the page (individual and groups) and creating a driving route for it. It seems like what's in dev is that that black button is misnamed. |
Thanks Karen, yes that is helpful and the animation is awesome. Couple of things about the 'view route' on a single mission :
Also perhaps the view route functionality should be available for the 'assigned' stage as well as the 'in progress' stage? I don't see why not? Why not even the suggested stage? |
Actual
Additional master view route seems to aggregate and show all available routes
Expected / Suggested
Context is modified so that bottom view route is changed to something like 'View All Routes' or 'Master Route', consider further discussion about how this might be impacted as more routes that fall within In Progress get further physically away from one another
The text was updated successfully, but these errors were encountered: