Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove colorama from dependencies? #1672

Open
Jeremiah-England opened this issue Jan 2, 2025 · 1 comment
Open

Remove colorama from dependencies? #1672

Jeremiah-England opened this issue Jan 2, 2025 · 1 comment

Comments

@Jeremiah-England
Copy link

In nevergrad==1.0.4, colorama was added to the dependencies and locked the version to 0.4.0.

This means that this library cannot be used in apps that have a dependency on colorama > 0.4.0, unless they adopt a dependency manager that is OK with such conflicts (Poetry is not). We are pinned to nevergrad==1.0.3 to work around this.

However, none of the code in this project directly depends on colorama. The only place colorama shows up is in the file specifying the project dependencies.

In general, it is nice if the allowable versions of subdependencies is left up to the dependencies. And any issues with subdependency version compatibility are resolved in the upstream dependency probjects.

In this particular case, it looks like some people are having issues with this subdependency: #1492. I cannot reproduce what those individuals are experiencing on my Linux machine. But from my perspective, it isn't really nevergrad's responsibility to fix those issues, and they can just be forwarded to the dependency projects. Anyone experiencing subdependency issues can lock them themselves and comment on an issue in the upstream projects.

@bottler
Copy link
Contributor

bottler commented Jan 2, 2025

I think bayesian-optimization has now fixed the problem. It may be that we can just update the version of bayesian-optimization that nevergrad depends on and remove the colorama specification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants