Feature Request: Support for AMD GPUs

[alex-breslow-amd]

My team would find this useful. I don't have a good sense of how much additional work this is. @RihamSelim and the broader strobelight team, please let me know if this is something you plan to implement and open source.

[sonntex]

Hi @alex-breslow-amd,
We have the same functionality for AMD GPUs, but that code has not been opened yet.
What are your requirements and when do you expect this to be published at github?

[alex-breslow-amd]

@sonntex, I don't have any strict timelines. I'd just like to be able to replicate what has already been open sourced for NVIDIA GPUs on AMD GPUs. Strobelight is a great tool. It would be cool if more of it was open source. Let me know if this is something that you'd be open to doing. Beyond that, PC sampling with code attribution would be cool. I'm guessing this is also already implemented.

[sonntex]

Yes, for AMD GPUs we have event and memory profilers with the same features as for NVIDIA GPUs, plus AMD profiler is able to extract duration of kernels. I will publish this code to open source soon.

[sonntex]

@alex-breslow-amd Btw, before I publish AMD GPUs profilers, could you please help us to introduce a new USDT probe into ROCm/clr repo ROCm/clr#143? I published that PR even at the end of February and pinged engineers a couple of times in March via github and slack, and, unfortunately, no process on that. This should help to make a configuration of the profilers easier and more transparent.

[alex-breslow-amd]

I'll see what I can do @sonntex. Sorry for the belated reply. I was out with a respiratory infection and just saw your message.

[sonntex]

@alex-breslow-amd We really appreciate it! Have you managed to get any information about the status of that PR?

[alex-breslow-amd]

Sorry for the delay @sonntex, I haven't been able to get clarity yet. I have been pointed to someone on the AMD side who should have more context, but he's out on vacation until tomorrow.

[alex-breslow-amd]

@RihamSelim, just wanted to confirm that @sonntex works for Meta. Kindly let me know at your convenience.

[RihamSelim]

@alex-breslow-amd Yup, can confirm he is a member of the Strobelight team, please feel free to reach out directly to me as well at "rihams at meta.com" and I can start an email thread

[alex-breslow-amd]

@sonntex, I got some initial clarity from someone in the ROCm org. The interface you want to insert the USDT probe into is private and deprecated. I need to follow up internally to get you the interface that you should be using. It may be okay to merge the PR as is, but I need to check.

[sonntex]

@alex-breslow-amd Thanks! Yes, I remember that installing hooks via activity callback was marked as "soon to be deprecated". Other interfaces are more suited to the polling model. Do they create something suitable for USDT probes?