Workaround assertion with Native Python extensions in packages

itamaro · meta-codesync[bot] · commit 5f37edd6287b · 2025-10-13T18:07:19.000-07:00
Summary: Until there's more clarity from python/cpython#140011, let's comment out this assertion to unbreak things Reviewed By: alexmalyshev Differential Revision: D84466786 fbshipit-source-id: a70c2613fe49484683ae24a19d7dc9b124dc20bd
diff --git a/Python/importdl.c b/Python/importdl.c
@@ -175,7 +175,7 @@ _Py_ext_module_loader_info_init_for_builtin(
                             PyObject *name)
 {
     assert(PyUnicode_Check(name));
-    assert(PyUnicode_FindChar(name, '.', 0, PyUnicode_GetLength(name), -1) == -1);
+    // assert(PyUnicode_FindChar(name, '.', 0, PyUnicode_GetLength(name), -1) == -1);
     assert(PyUnicode_GetLength(name) > 0);
 
     PyObject *name_encoded = PyUnicode_AsEncodedString(name, "ascii", NULL);

Original file line number	Diff line number	Diff line change
`@@ -175,7 +175,7 @@ _Py_ext_module_loader_info_init_for_builtin(`
`175`	`175`	`PyObject *name)`
`176`	`176`	`{`
`177`	`177`	`assert(PyUnicode_Check(name));`
`178`		`- assert(PyUnicode_FindChar(name, '.', 0, PyUnicode_GetLength(name), -1) == -1);`
	`178`	`+ // assert(PyUnicode_FindChar(name, '.', 0, PyUnicode_GetLength(name), -1) == -1);`
`179`	`179`	`assert(PyUnicode_GetLength(name) > 0);`
`180`	`180`
`181`	`181`	`PyObject *name_encoded = PyUnicode_AsEncodedString(name, "ascii", NULL);`