Replace fmt with proper logging in blocks (#570)

Summary:
Pull Request resolved: #570

This change improves logging consistency by replacing direct `fmt.Printf` and `fmt.Println` calls with the structured logging package throughout the blocks package. Additionally updated testutils to not print to the screen.

This ensures all logging output uses the proper logging infrastructure (`logging.L().Errorf()` and `logging.L().Infof()`) which provides better log formatting, filtering, and consistency across the application.

Reviewed By: RoboticPrism

Differential Revision: D85156300

fbshipit-source-id: 7ac8e679c2600a9079dd8b7ee84fe7e0d208e84e

Author: isaac-fletcher

pkg/blocks/expectstep.go

@@ -184,7 +184,7 @@ func (s *ExpectStep) Execute(execCtx TTPExecutionContext) (*ActResult, error) {
 	}
 	defer func() {
 		if err := os.Chdir(originalDir); err != nil {
-			fmt.Printf("failed to change back to original directory: %v\n", err)
+			logging.L().Errorf("failed to change back to original directory: %w", err)
 		}
 	}()
 

pkg/blocks/killprocess.go

@@ -60,13 +60,13 @@ func (s *KillProcessStep) Validate(_ TTPExecutionContext) error {
 		return fmt.Errorf("Both Process ID and Process Name cannot be empty")
 	}
 	if s.ProcessID == "" {
-		fmt.Printf("Processing using process name: %v\n", s.ProcessName)
+		logging.L().Infof("Processing using process name: %v", s.ProcessName)
 		return nil
 	}
 	// Not handling for overflow
 	processID, err := strconv.Atoi(s.ProcessID)
 	if err != nil {
-		fmt.Printf("Failed to convert %v to int: %v\n", s.ProcessID, err)
+		logging.L().Errorf("Failed to convert %v to int: %w", s.ProcessID, err)
 		return fmt.Errorf("Invalid Process ID: %v", s.ProcessID)
 	}
 

pkg/testutils/kill_unix.go

@@ -32,7 +32,6 @@ func CreateProcessToTerminate() (int, error) {
 	cmd := exec.Command("ping", "-n", "60", "127.0.0.1")
 	err := cmd.Start()
 	if err != nil {
-		fmt.Println("Failed to start process:", err)
 		return 0, fmt.Errorf("Failed to start process: %w", err)
 	}
 	pid := cmd.Process.Pid

pkg/testutils/kill_windows.go

@@ -32,7 +32,6 @@ func CreateProcessToTerminate() (int, error) {
 	cmd := exec.Command("cmd.exe", "/C", "ping -n 60 127.0.0.1 > nul")
 	err := cmd.Start()
 	if err != nil {
-		fmt.Println("Failed to start process:", err)
 		return 0, fmt.Errorf("Failed to start process: %w", err)
 	}
 	pid := cmd.Process.Pid