Fix session cookie secure flag #112
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change updates the session initialization logic in
FacebookWordpressOpenBridge::start_new_php_session_if_needed()to set the$secureflag dynamically based on whether the site is served over HTTPS —$secure = is_ssl().Previously,
$securewas hardcoded tofalse, which could cause cookies to be sent over insecure connections even on HTTPS sites.This PR improves compliance with WordPress security best practices and prevents insecure session cookies from being set.
Type of change
Checklist
Changelog entry
Fix insecure session cookies by setting $secure based on
is_ssl()Test Plan