add status err if linked PR was closed when submitting (#356)

Summary:
add status err if linked PR was closed when submitting

 ---
Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/sapling/pull/356).
* __->__ #356

Pull Request resolved: #356

Reviewed By: akushner

Differential Revision: D42299786

Pulled By: bolinfest

fbshipit-source-id: dfc2e0b95bca998f3fdb2e87cf6649f622d0621b

Author: discentem

eden/scm/edenscm/ext/github/consts/query.py

@@ -40,6 +40,7 @@
     pullRequest(number: $number) {
       id
       url
+      state
       baseRefOid
       baseRefName
       headRefOid

eden/scm/edenscm/ext/github/gh_submit.py

@@ -10,6 +10,7 @@
 (2) do more work in parallel.
 """
 
+import enum
 from dataclasses import dataclass
 from typing import Dict, Optional, Tuple, Union
 
@@ -89,6 +90,17 @@ async def get_repository(
     return _parse_repository_from_dict(repo, hostname=hostname, upstream=upstream)
 
 
+class PullRequestState(enum.Enum):
+    """https://docs.github.com/en/graphql/reference/enums#pullrequeststate"""
+
+    """A pull request that has been closed without being merged."""
+    CLOSED = enum.auto()
+    """A pull request that has been closed by being merged."""
+    MERGED = enum.auto()
+    """A pull request that is still open."""
+    OPEN = enum.auto()
+
+
 @dataclass
 class PullRequestDetails:
     node_id: str
@@ -103,6 +115,7 @@ class PullRequestDetails:
     #   bodyText: plaintext version of body with Markdown markup removed
     #   bodyHTML: body rendered as "safe" HTML
     body: str
+    state: PullRequestState
 
 
 async def get_pull_request_details(
@@ -129,6 +142,7 @@ async def get_pull_request_details(
             head_oid=data["headRefOid"],
             head_branch_name=data["headRefName"],
             body=data["body"],
+            state=PullRequestState[data["state"]],
         )
     )
 

eden/scm/edenscm/ext/github/mock_utils.py

@@ -8,6 +8,7 @@
 from typing import Any, Callable, Dict, List, Optional, Union
 
 from edenscm.ext.github.consts import query
+from edenscm.ext.github.gh_submit import PullRequestState
 from edenscm.ext.github.pull_request_body import firstline
 from edenscm.result import Ok, Result
 
@@ -401,6 +402,7 @@ def __init__(self, key: str, owner: str, name: str, pr_number: int) -> None:
     def and_respond(
         self,
         pr_id: str,
+        state: PullRequestState = PullRequestState.OPEN,
         head_ref_name: str = "",
         head_ref_oid: str = "",
         base_ref_name: str = "main",
@@ -416,6 +418,7 @@ def and_respond(
                     "pullRequest": {
                         "id": pr_id,
                         "url": f"https://github.com/{self._owner}/{self._name}/pull/{self._pr_number}",
+                        "state": state.name,
                         "headRefOid": head_ref_oid,
                         "headRefName": head_ref_name,
                         "baseRefOid": base_ref_oid,

eden/scm/edenscm/ext/github/submit.py

@@ -15,7 +15,7 @@
 
 from . import gh_submit, github_repo_util
 from .archive_commit import add_commit_to_archives
-from .gh_submit import PullRequestDetails, Repository
+from .gh_submit import PullRequestDetails, PullRequestState, Repository
 from .github_repo_util import check_github_repo, GitHubRepo
 from .none_throws import none_throws
 from .pr_parser import get_pull_request_for_context
@@ -440,7 +440,12 @@ async def create_placeholder_strategy_params(
         pr = commit.pr
         if pr:
             if pr.head_oid == hex(commit.node):
-                ui.status_err(_("#%d is up-to-date\n") % pr.number)
+                if pr.state == PullRequestState.CLOSED:
+                    ui.status_err(_("%s was closed.\n") % pr.url)
+                elif pr.state == PullRequestState.MERGED:
+                    ui.status_err(_("%s was merged.\n") % pr.url)
+                else:
+                    ui.status_err(_("#%d is up-to-date\n") % pr.number)
             else:
                 refs_to_update.append(
                     f"{hex(commit.node)}:refs/heads/{pr.head_branch_name}"