Move Static Fields to package.json: reactdevtools

Summary:
Flipper reads metadata to show on the sidebar from `package.json` and static fields (`id`, `title`, and `icon`) from `FlipperPlugin` class. If there are fields declared in both file, `FlipperPlugin` class takes precedences.

With Sandy (new Flipper plugin API), there is no static field available. In order to prevent unexpected scenario happening when migrating to Sandy, this codemod-ish is applied to plugins that contain static field.

The static fields are merged into `package.json` to get the same result. In addition, the static fields are also removed.

Reviewed By: mweststrate

Differential Revision: D22411845

fbshipit-source-id: b6f043e74358a9a66d5d466a17252820d712b71c

Author: Chaiwat Ekkaewnumchai

desktop/plugins/reactdevtools/index.tsx

@@ -99,14 +99,10 @@ enum ConnectionStatus {
 }
 
 export default class ReactDevTools extends FlipperDevicePlugin<
-  {
-    status: string;
-  },
+  {status: string},
   any,
   {}
 > {
-  static id = 'React';
-
   static supportsDevice(device: Device) {
     return !device.isArchived && device.os === 'Metro';
   }

desktop/plugins/reactdevtools/package.json

@@ -1,7 +1,7 @@
 {
   "$schema": "https://fbflipper.com/schemas/plugin-package/v2.json",
   "name": "flipper-plugin-react-devtools",
-  "id": "flipper-plugin-react-devtools",
+  "id": "React",
   "version": "0.49.0",
   "main": "dist/bundle.js",
   "flipperBundlerEntry": "index.tsx",