Add field for optics communication errors

Summary: adding a field so that we can indicate when we fail to communicate with the module

Reviewed By: harshitgulati18

Differential Revision: D86231781

fbshipit-source-id: d5716da1e6b8fcc96d5cbf0f7d92e5797ae75758

Author: Chet Powers

fboss/fsdb/if/oss/fsdb_model_thriftpath.h

@@ -181,7 +181,8 @@ std::pair<strings::fwUpgradeInProgress, Child<bool, ::apache::thrift::type_class
 std::pair<strings::interfaces, ChildThriftPath<::std::set<::std::string>, ::facebook::fboss::fsdb::FsdbOperStateRoot, Self>>,
 std::pair<strings::tcvrName, Child<::std::string, ::apache::thrift::type_class::string, ::apache::thrift::type::string_t>>,
 std::pair<strings::lpoModule, Child<bool, ::apache::thrift::type_class::integral, ::apache::thrift::type::bool_t>>,
-std::pair<strings::tunableLaserStatus, ChildThriftPath<::facebook::fboss::TunableLaserStatus, ::facebook::fboss::fsdb::FsdbOperStateRoot, Self>>>;
+std::pair<strings::tunableLaserStatus, ChildThriftPath<::facebook::fboss::TunableLaserStatus, ::facebook::fboss::fsdb::FsdbOperStateRoot, Self>>,
+std::pair<strings::communicationError, Child<bool, ::apache::thrift::type_class::integral, ::apache::thrift::type::bool_t>>>;
   using ChildrenById = fatal::tuple<   std::pair<std::integral_constant<apache::thrift::field_id_t, 1>, Child<bool, ::apache::thrift::type_class::integral, ::apache::thrift::type::bool_t>>,
    std::pair<std::integral_constant<apache::thrift::field_id_t, 2>, Child<::facebook::fboss::TransceiverType, ::apache::thrift::type_class::enumeration, ::apache::thrift::type::enum_t<::facebook::fboss::TransceiverType>>>,
    std::pair<std::integral_constant<apache::thrift::field_id_t, 3>, Child<::std::int32_t, ::apache::thrift::type_class::integral, ::apache::thrift::type::i32_t>>,
@@ -207,7 +208,8 @@ std::pair<strings::tunableLaserStatus, ChildThriftPath<::facebook::fboss::Tunabl
    std::pair<std::integral_constant<apache::thrift::field_id_t, 26>, ChildThriftPath<::std::set<::std::string>, ::facebook::fboss::fsdb::FsdbOperStateRoot, Self>>,
    std::pair<std::integral_constant<apache::thrift::field_id_t, 27>, Child<::std::string, ::apache::thrift::type_class::string, ::apache::thrift::type::string_t>>,
    std::pair<std::integral_constant<apache::thrift::field_id_t, 28>, Child<bool, ::apache::thrift::type_class::integral, ::apache::thrift::type::bool_t>>,
-   std::pair<std::integral_constant<apache::thrift::field_id_t, 29>, ChildThriftPath<::facebook::fboss::TunableLaserStatus, ::facebook::fboss::fsdb::FsdbOperStateRoot, Self>>>;
+   std::pair<std::integral_constant<apache::thrift::field_id_t, 29>, ChildThriftPath<::facebook::fboss::TunableLaserStatus, ::facebook::fboss::fsdb::FsdbOperStateRoot, Self>>,
+   std::pair<std::integral_constant<apache::thrift::field_id_t, 30>, Child<bool, ::apache::thrift::type_class::integral, ::apache::thrift::type::bool_t>>>;
   template <typename Name>
   using NameToId = fatal::tuple<std::pair<strings::present, std::integral_constant<apache::thrift::field_id_t, 1>>,
 std::pair<strings::transceiver, std::integral_constant<apache::thrift::field_id_t, 2>>,
@@ -234,7 +236,8 @@ std::pair<strings::fwUpgradeInProgress, std::integral_constant<apache::thrift::f
 std::pair<strings::interfaces, std::integral_constant<apache::thrift::field_id_t, 26>>,
 std::pair<strings::tcvrName, std::integral_constant<apache::thrift::field_id_t, 27>>,
 std::pair<strings::lpoModule, std::integral_constant<apache::thrift::field_id_t, 28>>,
-std::pair<strings::tunableLaserStatus, std::integral_constant<apache::thrift::field_id_t, 29>>>::template type_of<Name>;
+std::pair<strings::tunableLaserStatus, std::integral_constant<apache::thrift::field_id_t, 29>>,
+std::pair<strings::communicationError, std::integral_constant<apache::thrift::field_id_t, 30>>>::template type_of<Name>;
 
   template <typename Name>
   using TypeFor = typename Children::template type_of<Name>;
@@ -266,6 +269,7 @@ std::pair<strings::tunableLaserStatus, std::integral_constant<apache::thrift::fi
     STRUCT_CHILD_GETTERS(tcvrName, 27);
     STRUCT_CHILD_GETTERS(lpoModule, 28);
     STRUCT_CHILD_GETTERS(tunableLaserStatus, 29);
+    STRUCT_CHILD_GETTERS(communicationError, 30);
 
   template <apache::thrift::field_id_t __id>
   auto operator()(const std::integral_constant<apache::thrift::field_id_t, __id>&) {
@@ -295,6 +299,7 @@ std::pair<strings::tunableLaserStatus, std::integral_constant<apache::thrift::fi
     else if constexpr (__id == 27) { return tcvrName(); }
     else if constexpr (__id == 28) { return lpoModule(); }
     else if constexpr (__id == 29) { return tunableLaserStatus(); }
+    else if constexpr (__id == 30) { return communicationError(); }
   }
 
   template <typename T, T... Values>

fboss/qsfp_service/if/transceiver.thrift

@@ -601,6 +601,9 @@ struct TcvrState {
   27: string tcvrName;
   28: bool lpoModule;
   29: optional TunableLaserStatus tunableLaserStatus;
+  // Will be set to true if the last attempt to read data from this transceiver
+  // was unsuccessful
+  30: bool communicationError;
 }
 
 struct TcvrStats {