test: allow buck2.test_builds_targets to build all RunInfo and DefaultInfos by default

Signed-off-by: Austin Seipp <[email protected]>

Author: thoughtpolice

app/buck2_client/src/commands/test.rs

@@ -159,7 +159,6 @@ If include patterns are present, regardless of whether exclude patterns are pres
     build_default_info: bool,
 
     /// Do not build DefaultInfo provider (this is the default)
-    #[allow(unused)]
     #[clap(long, group = "default-info")]
     skip_default_info: bool,
 
@@ -168,7 +167,6 @@ If include patterns are present, regardless of whether exclude patterns are pres
     build_run_info: bool,
 
     /// Do not build RunInfo provider (this is the default)
-    #[allow(unused)]
     #[clap(long, group = "run-info")]
     skip_run_info: bool,
 
@@ -205,6 +203,23 @@ impl StreamingCommand for TestCommand {
         events_ctx: &mut EventsCtx,
     ) -> ExitResult {
         let context = ctx.client_context(matches, &self)?;
+
+        let build_default_info = if self.skip_default_info {
+            false
+        } else if self.build_default_info {
+            true
+        } else {
+            ctx.test_builds_targets()?
+        };
+
+        let build_run_info = if self.skip_run_info {
+            false
+        } else if self.build_run_info {
+            true
+        } else {
+            ctx.test_builds_targets()?
+        };
+
         let response = buckd
             .with_flushing()
             .test(
@@ -228,8 +243,8 @@ impl StreamingCommand for TestCommand {
                     }),
                     timeout: self.timeout_options.overall_timeout()?,
                     ignore_tests_attribute: self.ignore_tests_attribute,
-                    build_default_info: self.build_default_info,
-                    build_run_info: self.build_run_info,
+                    build_default_info,
+                    build_run_info,
                 },
                 events_ctx,
                 ctx.console_interaction_stream(&self.common_opts.console_opts),

app/buck2_client_ctx/src/client_ctx.rs

@@ -292,6 +292,14 @@ impl<'a> ClientCommandContext<'a> {
             .log_download_method
             .clone())
     }
+
+    pub fn test_builds_targets(&self) -> buck2_error::Result<bool> {
+        Ok(self
+            .immediate_config
+            .daemon_startup_config()?
+            .test_builds_targets
+            .clone())
+    }
 }
 
 /// Provides a common interface for buck subcommands that use event subscribers for logging.

app/buck2_common/src/init.rs

@@ -446,6 +446,7 @@ pub struct DaemonStartupConfig {
     pub resource_control: ResourceControlConfig,
     pub log_download_method: LogDownloadMethod,
     pub health_check_config: HealthCheckConfig,
+    pub test_builds_targets: bool,
 }
 
 impl DaemonStartupConfig {
@@ -521,6 +522,12 @@ impl DaemonStartupConfig {
             resource_control: ResourceControlConfig::from_config(config)?,
             log_download_method,
             health_check_config: HealthCheckConfig::from_config(config)?,
+            test_builds_targets: config
+                .parse(BuckconfigKeyRef {
+                    section: "buck2",
+                    property: "test_builds_targets",
+                })?
+                .unwrap_or(false),
         })
     }
 
@@ -548,6 +555,7 @@ impl DaemonStartupConfig {
                 LogDownloadMethod::None
             },
             health_check_config: HealthCheckConfig::default(),
+            test_builds_targets: false,
         }
     }
 }