Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Sponsored Marketplace ads not suppressed #107

Open
Kronzky opened this issue Oct 24, 2021 · 6 comments
Open

[Feature] Sponsored Marketplace ads not suppressed #107

Kronzky opened this issue Oct 24, 2021 · 6 comments

Comments

@Kronzky
Copy link

Kronzky commented Oct 24, 2021

Environment

  • Extension version: 1.9.5
  • Browser and version: Brave (Chromium) 1.31.87
  • OS and version: Win10 21H1

Describe the bug
Sponsored ads on Marketplace are not blocked.

Screenshots of console
https://imgur.com/5XlUrFN

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Marketplace'
  2. Scroll down a few pages
  3. Sponsored ads show up

Expected behavior
Sponsored ads should be hidden (most of them are scams)

@Kronzky Kronzky added the bug label Oct 24, 2021
@cbotsikas cbotsikas added feature and removed bug labels Oct 25, 2021
@cbotsikas cbotsikas changed the title [BUG] Sponsored Marketplace ads not suppressed [Feature] Sponsored Marketplace ads not suppressed Oct 25, 2021
@cbotsikas
Copy link
Collaborator

Marketplace ads are not detected, that would be a new feature. Contribution is welcome

@Dark3n89
Copy link

Dark3n89 commented Jan 7, 2022

Marketplace ads are not detected, that would be a new feature. Contribution is welcome

Hi i make today work script for delete ads from marketplace and marketplace/category how i can share? Will you add into your code?

@tiratatp
Copy link
Collaborator

tiratatp commented Jan 7, 2022

Marketplace ads are not detected, that would be a new feature. Contribution is welcome

Hi i make today work script for delete ads from marketplace and marketplace/category how i can share? Will you add into your code?

You can send a pull request (PR), https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/about-pull-requests

@Dark3n89
Copy link

Environment

  • Extension version: 1.9.5
  • Browser and version: Brave (Chromium) 1.31.87
  • OS and version: Win10 21H1

Describe the bug Sponsored ads on Marketplace are not blocked.

Screenshots of console https://imgur.com/5XlUrFN

To Reproduce Steps to reproduce the behavior:

  1. Go to 'Marketplace'
  2. Scroll down a few pages
  3. Sponsored ads show up

Expected behavior Sponsored ads should be hidden (most of them are scams)

is it only first BETA but i add my code to this code and marketplace is clean userscript

@tiratatp
Copy link
Collaborator

Environment

  • Extension version: 1.9.5
  • Browser and version: Brave (Chromium) 1.31.87
  • OS and version: Win10 21H1

Describe the bug Sponsored ads on Marketplace are not blocked.
Screenshots of console https://imgur.com/5XlUrFN
To Reproduce Steps to reproduce the behavior:

  1. Go to 'Marketplace'
  2. Scroll down a few pages
  3. Sponsored ads show up

Expected behavior Sponsored ads should be hidden (most of them are scams)

is it only first BETA but i add my code to this code and marketplace is clean userscript

Good start. Let me take a look.

@tiratatp
Copy link
Collaborator

Environment

  • Extension version: 1.9.5
  • Browser and version: Brave (Chromium) 1.31.87
  • OS and version: Win10 21H1

Describe the bug Sponsored ads on Marketplace are not blocked.
Screenshots of console https://imgur.com/5XlUrFN
To Reproduce Steps to reproduce the behavior:

  1. Go to 'Marketplace'
  2. Scroll down a few pages
  3. Sponsored ads show up

Expected behavior Sponsored ads should be hidden (most of them are scams)

is it only first BETA but i add my code to this code and marketplace is clean userscript

I looked at the code. In our extension, I tried to consider performance when blocking things. That's why we don't use setInterval here but use mutation observer https://developer.mozilla.org/en-US/docs/Web/API/MutationObserver.

Another feedback is that the obfuscated class name are not a good filter since they change often.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants