Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken module instantiation #92

Closed
mymmrac opened this issue Jan 14, 2025 · 1 comment · Fixed by #93
Closed

Broken module instantiation #92

mymmrac opened this issue Jan 14, 2025 · 1 comment · Fixed by #93
Assignees

Comments

@mymmrac
Copy link
Contributor

mymmrac commented Jan 14, 2025

On the latest main branch (bef00f3) only main WASM module gets instantiated and all other modules are only compiled, but not instantiated.

In release version v1.6.1 there is c.Wazero.InstantiateWithConfig(ctx, data.Data, moduleConfig.WithName(data.Name)) which instantiates modules with a specified name, but in the main branch there is no instantiation of other modules, only compilation.

Simplest example to reproduce is https://github.com/mhmd-azeez/extism_link_modules, with v1.6.1 works as expected, but on latest main it fails with the error:

Failed to initialize plugin: instantiating module: module[lib] not instantiated
@mhmd-azeez
Copy link
Collaborator

Hello @mymmrac thank you very much for reporting the bug, I have opened a PR that should fix it: #93

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants