Skip to content

get failing after 1.17.0 #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tarasyarema opened this issue Apr 29, 2025 · 0 comments · May be fixed by #786
Open

get failing after 1.17.0 #785

tarasyarema opened this issue Apr 29, 2025 · 0 comments · May be fixed by #786

Comments

@tarasyarema
Copy link
Contributor

I started to get cannot fetch struct from <nil> after the 1.17.0 release. Seems weird as It seems the whole point was to improve that function.

Seems like an issue in 435b79d#diff-af7c4544b9d6b20c320816544b93248b632a6600a1b31e18960020755a5ec753R377

Before something like this {} | get("struct") | get("asdf") worked and yielded nil which was useful, not sure if that was intended or not.

Any comments? Happy to make a PR with a change to this, or maybe implement a safe get, e.g. with a fallback

{} | get("struct", {}) | get("asdf") == nil
@tarasyarema tarasyarema linked a pull request Apr 29, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(785): get to work when return is nil tarasyarema/expr
1 participant
@tarasyarema