Skip to content

Commit 7627b42

Browse files
authored
remove x-requested-with requirement (#703)
1 parent 910cb71 commit 7627b42

File tree

2 files changed

+12
-21
lines changed

2 files changed

+12
-21
lines changed

explorer/tests/test_views.py

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -836,28 +836,17 @@ def test_email_calls_task(self, mocked_execute):
836836
self.client.post(
837837
url,
838838
data={"email": "[email protected]"},
839-
**{"HTTP_X_REQUESTED_WITH": "XMLHttpRequest"}
840839
)
841840
self.assertEqual(mocked_execute.delay.call_count, 1)
842841

843-
def test_email_403(self):
842+
def test_no_email(self):
844843
query = SimpleQueryFactory()
845844
url = reverse("email_csv_query", kwargs={"query_id": query.id})
846845
response = self.client.post(
847846
url,
848847
data={},
849-
**{"HTTP_X_REQUESTED_WITH": "XMLHttpRequest"}
850848
)
851-
self.assertEqual(response.status_code, 403)
852-
853-
def test_email_no_xml_403(self):
854-
query = SimpleQueryFactory()
855-
url = reverse("email_csv_query", kwargs={"query_id": query.id})
856-
response = self.client.post(
857-
url,
858-
data={},
859-
)
860-
self.assertEqual(response.status_code, 403)
849+
self.assertEqual(response.status_code, 400)
861850

862851

863852
class TestQueryFavorites(TestCase):

explorer/views/email.py

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,13 @@ class EmailCsvQueryView(PermissionRequiredMixin, View):
1010
permission_required = "view_permission"
1111

1212
def post(self, request, query_id, *args, **kwargs):
13-
if request.headers.get("x-requested-with") == "XMLHttpRequest":
14-
email = request.POST.get("email", None)
15-
if email:
16-
execute_query.delay(query_id, email)
17-
return JsonResponse(
18-
{"message": "message was sent successfully"}
19-
)
20-
return JsonResponse({}, status=403)
13+
email = request.POST.get("email", None)
14+
if not email:
15+
return JsonResponse(
16+
{"error": "email is required"},
17+
status=400,
18+
)
19+
20+
execute_query.delay(query_id, email)
21+
22+
return JsonResponse({"message": "message was sent successfully"})

0 commit comments

Comments
 (0)