Skip to content

fix issue 1857#2082

Closed
crisschan wants to merge 7 commits intovibrantlabsai:mainfrom
crisschan:main
Closed

fix issue 1857#2082
crisschan wants to merge 7 commits intovibrantlabsai:mainfrom
crisschan:main

Conversation

@crisschan
Copy link
Copy Markdown

add OllamaLLMWrapper class major at change from ChatOllama type to ChatOpenAI.

add new file ollama_warpper.py,change the ChatOllama class to ChatOpenAI.
@dosubot dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jun 18, 2025
@crisschan
Copy link
Copy Markdown
Author

add langchain_ollama to /ragas/pyproject.toml

1 change the llm from ChatOpenAI api to ChatOllama
2 change the generate_text and  agenerate_text return type LLMResult
add the ollama embedding model class
Copy link
Copy Markdown
Member

@anistark anistark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crisschan There are several conflicts. Could you please rebase this PR so we can continue?

@anistark
Copy link
Copy Markdown
Member

Upon further checking, this PR might not be needed.
Ollama already works with existing langchain and ragas has moved to use factory rather than wrappers.

In case, there's an issue with the usage, can take up as a separate PR.

@anistark anistark closed this Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants