Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different approach suggestion #9

Open
andrerferreira opened this issue Mar 6, 2023 · 1 comment
Open

Different approach suggestion #9

andrerferreira opened this issue Mar 6, 2023 · 1 comment

Comments

@andrerferreira
Copy link

Hi Victor,

I rarely contribute to company projects of which I'm not a part of, but I've been inspired by what you are going to achieve so I've decided to make a suggestion for a different approach that you may have not thought about, for your consideration.

In the browser you have a way to know if the user has defined language preferences, as such, only in those circumstances does it make sense to send the 1st request as HEAD as to negotiate with the server.

This approach restricts the implementation to only users that do set language preferences and is less wasteful than a full GET request that may or may not have to be resent asking for the preferred languages from those available in the server.

Hope the above helps!
Best regards
André

@andrerferreira andrerferreira changed the title Different approach suggestion Potential improvement suggestion Mar 7, 2023
@andrerferreira andrerferreira changed the title Potential improvement suggestion Different approach suggestion Mar 7, 2023
@Tanych
Copy link
Collaborator

Tanych commented Mar 10, 2023

Thanks for your suggestion, what we do is trying to reuse the existing architecture in Chromium to resent the request. Also, this introduce a hard dependency, all sites should support the HEAD request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants