Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

from_pdf() works for Scenario but not ScenarioList #1487

Closed
rbyh opened this issue Jan 14, 2025 · 1 comment
Closed

from_pdf() works for Scenario but not ScenarioList #1487

rbyh opened this issue Jan 14, 2025 · 1 comment
Assignees
@johnjosephhorton
Labels
bug Something isn't working

Comments

@rbyh
Copy link
Contributor

rbyh commented Jan 14, 2025

https://www.expectedparrot.com/content/c60818d3-c486-421c-b8f5-02d78ff6e18a

ScenarioList method:

edsl/edsl/scenarios/ScenarioListPdfMixin.py

Line 112 in 8cf255c

def from_pdf(cls, filename_or_url, collapse_pages=False):

Method should be available for Scenario object too:

edsl/edsl/scenarios/Scenario.py

Line 358 in 8cf255c

def from_pdf(cls, pdf_path: str):

PDFExtractor issue?
@rbyh rbyh added the bug Something isn't working label Jan 14, 2025
@rbyh
Copy link
Contributor Author

rbyh commented Jan 21, 2025

Fixed by #1503

@rbyh rbyh closed this as completed Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnjosephhorton johnjosephhorton

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@johnjosephhorton @rbyh