binary-search-tree: test_inserting_same may be inaccurate/confusing

[BradleyJohnson]

  def test_inserting_same
    four = Bst.new 4
    four.insert 4
    assert_equal 4, four.data
    assert_equal 4, four.left.data
  end

As I understand it, this test asserts for the behavior of a binary tree rather than a binary search tree. Adding a duplicate value should probably throw an exception or simply drop the duplicate, right? Happy to open a PR for this if folks agrees.

[Insti]

What does the canonical data say?

But it looks like these tests are not generated from the canonical data.

Any PR that improves things is strongly encouraged.

There's another issue about this exercise, maybe you also have an opinion on that:
#513

[BradleyJohnson]

@Insti Canonical data agrees with the current implementation. I suppose the behavior of duplicate inserts is dependant on application rather than some strict interpretation of the data structure. I'll close this, sorry for the noise!

[Insti]

It is always possible that the canonical-data is incorrect.

Thanks for making an issue anyway ❤️